Add missing braces in bnx2x:bnx2x_link_initialize

Add missing braces in bnx2x:bnx2x_link_initialize

[Dave Jones]

The indentation here implies that the intent was for this to be a multiline if.
Introduced a few years ago in commit ec146a6f019923819f5ca381980248b6d154ca1a ("bnx2x: Modify XGXS functions")

Signed-off-by: Dave Jones <davej@fedoraproject.org>

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
index 9d64b98..6645684 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
@@ -6501,12 +6501,13 @@ static int bnx2x_link_initialize(struct link_params *params,
 		struct bnx2x_phy *phy = &params->phy[INT_PHY];
 		if (vars->line_speed == SPEED_AUTO_NEG &&
 		    (CHIP_IS_E1x(bp) ||
-		     CHIP_IS_E2(bp)))
+		     CHIP_IS_E2(bp))) {
 			bnx2x_set_parallel_detection(phy, params);
 			if (params->phy[INT_PHY].config_init)
 				params->phy[INT_PHY].config_init(phy,
 								 params,
 								 vars);
+		}
 	}
 
 	/* Init external phy*/

Re: Add missing braces in bnx2x:bnx2x_link_initialize

[David Miller]

David, I'm going to apply your missing braces patches, but I'm really irritated
that I've told you at least 5 times to put proper subsystem prefixes into
your subject lines.

For this I'd use "bnx2x: ", for the TCP patch I'd use "tcp: " and for the
CAIF change I'd use "caif: "

Please get into the habit of doing this, or I'm going to push back on you
to correct this instead of fixing it up automatically for you every time,
since the latter really is not scalable.

Re: Add missing braces in bnx2x:bnx2x_link_initialize

[Dave Jones]

On Thu, Sep 05, 2013 at 02:21:17PM -0400, David Miller wrote:
 > 
 > David, I'm going to apply your missing braces patches, but I'm really irritated
 > that I've told you at least 5 times to put proper subsystem prefixes into
 > your subject lines.
 > 
 > For this I'd use "bnx2x: ", for the TCP patch I'd use "tcp: " and for the
 > CAIF change I'd use "caif: "

I knew I'd forget something..

 > Please get into the habit of doing this, or I'm going to push back on you
 > to correct this instead of fixing it up automatically for you every time,
 > since the latter really is not scalable.

Sure thing.

thanks,

	Dave