From: Willy Tarreau <w@1wt.eu>
To: Ethan Tuttle <ethan@ethantuttle.com>
Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Lior Amsalem" <alior@marvell.com>,
"Jochen De Smet" <jochen.armkernel@leahnim.org>,
"Simon Guinot" <simon.guinot@sequanux.org>,
"Ryan Press" <ryan@presslab.us>,
netdev@vger.kernel.org, vdonnefort@lacie.com,
stable@vger.kernel.org,
"Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>,
"Chény Yves-Gael" <yves@cheny.fr>,
"Gregory Clement" <gregory.clement@free-electrons.com>,
"Peter Sanford" <psanford@nearbuy.io>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: mvneta: properly disable HW PHY polling and ensure adjust_link() works
Date: Thu, 5 Sep 2013 07:12:23 +0200 [thread overview]
Message-ID: <20130905051223.GB26000@1wt.eu> (raw)
In-Reply-To: <CACzLR4uDQK2bkcEJQXLe805EfSA8=eF+YH-FTYovHA0q+8Y9NA@mail.gmail.com>
Hi,
On Wed, Sep 04, 2013 at 09:14:23PM -0700, Ethan Tuttle wrote:
> Just booted with the patch on my Mirabox. Both interfaces work!
> Thank you Thomas.
>
> One remaining issue is that the interface which uBoot didn't configure
> is still getting a random mac address:
>
> mvneta d0070000.ethernet eth0: Using hardware mac address f0:ad:4e:01:dc:97
> mvneta d0074000.ethernet eth1: Using random mac address d2:35:dd:c8:99:48
>
> This is on 3.11 plus Thomas' patch, which includes the previous fix to
> "read MAC address from hardware when available". Perhaps that fix
> isn't working with the phylib?
No this is unrelated. The MAC isn't configured by the boot loader when
the NIC is not used. U-boot only passes it as a non-standard ATAG. I
have some patches to reinject the non-standard atags into the device
tree if you absolutely need this, but they're not suited for mainline
inclusion from what I understood last time I proposed them (they use
a marvell-specific atag header).
Regards,
Willy
next prev parent reply other threads:[~2013-09-05 5:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 14:21 [PATCH] net: mvneta: properly disable HW PHY polling and ensure adjust_link() works Thomas Petazzoni
2013-09-04 14:50 ` Jason Cooper
2013-09-04 15:20 ` Vincent Donnefort
2013-09-04 16:00 ` yves
2013-09-05 18:51 ` David Miller
2013-09-04 16:08 ` Gregory CLEMENT
2013-09-04 16:32 ` Willy Tarreau
2013-09-05 4:14 ` Ethan Tuttle
2013-09-05 5:12 ` Willy Tarreau [this message]
2013-09-05 5:22 ` Ethan Tuttle
2013-09-05 6:23 ` yves
2013-09-05 6:40 ` Willy Tarreau
2013-09-05 6:52 ` Ethan Tuttle
2013-09-05 7:28 ` Thomas Petazzoni
2013-09-05 7:44 ` Willy Tarreau
2013-09-05 8:26 ` Thomas Petazzoni
2013-09-05 9:11 ` Willy Tarreau
2013-09-05 9:24 ` Thomas Petazzoni
2013-09-05 11:38 ` Jason Cooper
2013-09-05 11:36 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905051223.GB26000@1wt.eu \
--to=w@1wt.eu \
--cc=alior@marvell.com \
--cc=davem@davemloft.net \
--cc=ethan@ethantuttle.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jochen.armkernel@leahnim.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=psanford@nearbuy.io \
--cc=ryan@presslab.us \
--cc=simon.guinot@sequanux.org \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=vdonnefort@lacie.com \
--cc=yves@cheny.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).