From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Willy Tarreau <w@1wt.eu>
Cc: "Ethan Tuttle" <ethan@ethantuttle.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Lior Amsalem" <alior@marvell.com>,
"Gregory Clement" <gregory.clement@free-electrons.com>,
"Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>,
"Jochen De Smet" <jochen.armkernel@leahnim.org>,
"Peter Sanford" <psanford@nearbuy.io>,
"Chény Yves-Gael" <yves@cheny.fr>,
"Ryan Press" <ryan@presslab.us>,
"Simon Guinot" <simon.guinot@sequanux.org>,
vdonnefort@lacie.com, stable@vger.kernel.org,
"Jason Cooper" <jason@lakedaemon.net>
Subject: Re: [PATCH] net: mvneta: properly disable HW PHY polling and ensure adjust_link() works
Date: Thu, 5 Sep 2013 09:28:08 +0200 [thread overview]
Message-ID: <20130905092808.617da416@skate> (raw)
In-Reply-To: <20130905051223.GB26000@1wt.eu>
Hello,
On Thu, 5 Sep 2013 07:12:23 +0200, Willy Tarreau wrote:
> > This is on 3.11 plus Thomas' patch, which includes the previous fix to
> > "read MAC address from hardware when available". Perhaps that fix
> > isn't working with the phylib?
>
> No this is unrelated. The MAC isn't configured by the boot loader when
> the NIC is not used. U-boot only passes it as a non-standard ATAG. I
> have some patches to reinject the non-standard atags into the device
> tree if you absolutely need this, but they're not suited for mainline
> inclusion from what I understood last time I proposed them (they use
> a marvell-specific atag header).
I indeed submitted a revised/improved version of your patches some time
ago, but they were rejected. See
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-June/173201.html.
Since this has been rejected, the available options are:
(1) Use a DT-capable bootloader that will properly set the MAC
addresses in the DT. Such DT capable bootloaders will soon be made
available by Marvell, but I am really unsure Globalscale will
provide an update for the Mirabox bootloader, rebased on the new
Marvell bootloader that will be DT capable.
As an alternative, we (mainly Sebastian Hesselbarth and myself)
have started adding Armada 370/XP support in the Barebox
bootloader. We can already start Barebox on the Mirabox, but for
now it's quite useless since only the serial port is supported,
there is still no support for the network, SD card, USB or NAND.
This will probably come over time, but it's not going to happen
overnight.
(2) Use the "impedance matcher" code written by Daniel Mack and
extended by Jason Cooper, available at
https://github.com/zonque/pxa-impedance-matcher. Essentially, it
inserts a small binary between the installed bootloader and the
kernel, that for example allows to choose a particular DTB amongst
several, depending on the board that is detected. I believe it
could probably be extended to cover other use cases such as
modifying the DTB to add the MAC addresses where appropriate. I've
added Jason Cooper in the Cc list if he wants to comment on that.
(3) Continue to manually apply the patches from Willy that add support
for the Marvell-specific ATAGs.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-09-05 7:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 14:21 [PATCH] net: mvneta: properly disable HW PHY polling and ensure adjust_link() works Thomas Petazzoni
2013-09-04 14:50 ` Jason Cooper
2013-09-04 15:20 ` Vincent Donnefort
2013-09-04 16:00 ` yves
2013-09-05 18:51 ` David Miller
2013-09-04 16:08 ` Gregory CLEMENT
2013-09-04 16:32 ` Willy Tarreau
2013-09-05 4:14 ` Ethan Tuttle
2013-09-05 5:12 ` Willy Tarreau
2013-09-05 5:22 ` Ethan Tuttle
2013-09-05 6:23 ` yves
2013-09-05 6:40 ` Willy Tarreau
2013-09-05 6:52 ` Ethan Tuttle
2013-09-05 7:28 ` Thomas Petazzoni [this message]
2013-09-05 7:44 ` Willy Tarreau
2013-09-05 8:26 ` Thomas Petazzoni
2013-09-05 9:11 ` Willy Tarreau
2013-09-05 9:24 ` Thomas Petazzoni
2013-09-05 11:38 ` Jason Cooper
2013-09-05 11:36 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905092808.617da416@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=davem@davemloft.net \
--cc=ethan@ethantuttle.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jochen.armkernel@leahnim.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=psanford@nearbuy.io \
--cc=ryan@presslab.us \
--cc=simon.guinot@sequanux.org \
--cc=stable@vger.kernel.org \
--cc=vdonnefort@lacie.com \
--cc=w@1wt.eu \
--cc=yves@cheny.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).