From: David Miller <davem@davemloft.net>
To: eilong@broadcom.com
Cc: netdev@vger.kernel.org, davej@redhat.com
Subject: Re: [PATCH net] bnx2x: Restore a call to config_init
Date: Fri, 06 Sep 2013 14:47:33 -0400 (EDT) [thread overview]
Message-ID: <20130906.144733.708978789363351557.davem@davemloft.net> (raw)
In-Reply-To: <1378461302.15758.2.camel@lb-tlvb-eilong.il.broadcom.com>
From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Fri, 6 Sep 2013 12:55:02 +0300
> Commit c0a77ec74f295013d7ba3204dd3ed25fccf83cb4 'bnx2x: Add missing braces in
> bnx2x:bnx2x_link_initialize' identified indentation problem, but resolved it
> by adding braces instead of fixing the indentation. The braces now prevents a
> config_init call in some cases, though it should be called regardless of that
> condition. This patch removes the braces and fix the confusing indentation
> that caused this mess.
>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied.
next prev parent reply other threads:[~2013-09-06 18:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 9:55 [PATCH net] bnx2x: Restore a call to config_init Eilon Greenstein
2013-09-06 13:08 ` Eric Dumazet
2013-09-06 18:47 ` David Miller [this message]
2013-09-06 22:39 ` Eric Dumazet
2013-09-07 10:35 ` Dmitry Kravkov
2013-09-07 14:43 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906.144733.708978789363351557.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@redhat.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).