From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH stable] ipv6: restrict neighbor entry creation to output flow Date: Mon, 9 Sep 2013 14:17:19 +0200 Message-ID: <20130909121719.GA3269@minipsycho.brq.redhat.com> References: <20130814150054.GB2723@order.stressinduktion.org> <20130815.155454.417440388188230172.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: hannes@stressinduktion.org, mleitner@redhat.com, netdev@vger.kernel.org, dbanerje@akamai.com, yoshfuji@linux-ipv6.org To: David Miller Return-path: Received: from mail-ee0-f49.google.com ([74.125.83.49]:62585 "EHLO mail-ee0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751321Ab3IIMRX (ORCPT ); Mon, 9 Sep 2013 08:17:23 -0400 Received: by mail-ee0-f49.google.com with SMTP id d41so3036938eek.8 for ; Mon, 09 Sep 2013 05:17:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130815.155454.417440388188230172.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Fri, Aug 16, 2013 at 12:54:54AM CEST, davem@davemloft.net wrote: >From: Hannes Frederic Sowa >Date: Wed, 14 Aug 2013 17:00:54 +0200 > >> On Wed, Aug 14, 2013 at 10:53:27AM -0300, Marcelo Ricardo Leitner wrote: >>> This patch is based on 3.2.y branch, the one used by reported. Please let me >>> know if it should be different. Thanks. >>> >>> ---8<--- >>> >>> Commit 0d6a77079c475033cb622c07c5a880b392ef664e introduced a regression on >>> which routes to local delivery would not work anymore. Like this: >>> >>> $ ip -6 route add local 2001::/64 dev lo >>> $ ping6 -c1 2001::9 >>> PING 2001::9(2001::9) 56 data bytes >>> ping: sendmsg: Invalid argument >>> >>> As this is a local delivery, that commit would not allow the creation of a >>> neighbor entry and thus the packet cannot be sent. >>> >>> But as TPROXY scenario actually needs to avoid the neighbor entry creation only >>> for input flow, this patch now limits previous patch to input flow, keeping >>> output as before that patch. >>> >>> Reported-by: Debabrata Banerjee >>> Signed-off-by: Marcelo Ricardo Leitner >>> CC: Hannes Frederic Sowa >> >> Looks good, thanks Marcelo! >> >> Acked-by: Hannes Frederic Sowa >> >> David, this patch is for all stable kernels except the 3.10 series. >> It does not apply cleanly throughout the whole longterm kernels but the >> changes should not be too difficult to adapt. Do you take care of this >> or can we do something to ease this process? > >I've queued it up for -stable, thanks. Hi Dave. When do you plan to push this to stable maintainers? Thanks! Jiri