From: Vladimir Murzin <murzin.v@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, ben@decadent.org.uk,
jeffrey.t.kirsher@intel.com, rdunlap@xenotime.net,
haicheng.lee@gmail.com
Subject: Re: [PATCH] pch_gbe: fix unmet direct dependency on PTP_1588_CLOCK_PCH
Date: Tue, 10 Sep 2013 04:29:38 +0200 [thread overview]
Message-ID: <20130910022936.GA3630@hp530> (raw)
In-Reply-To: <522E28E5.5010106@infradead.org>
On Mon, Sep 09, 2013 at 01:00:37PM -0700, Randy Dunlap wrote:
> On 09/09/13 12:28, Vladimir Murzin wrote:
> > While cross-building for PPC.
> >
> > warning: (PCH_GBE) selects PTP_1588_CLOCK_PCH which has unmet direct
> > dependencies (X86 || COMPILE_TEST)
> >
> > Both PCH_GBE and PPT_1588_CLOCK_PCH is only compatible with Intel
> > architecture. Add dependency on x86 for PCH_GBE. Keep COMPILE_TEST to allow
> > building on different arches.
> >
> > Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
> > ---
> > drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> > index cb22341..4a935ec 100644
> > --- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> > +++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> > @@ -4,7 +4,7 @@
> >
> > config PCH_GBE
> > tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
> > - depends on PCI
> > + depends on PCI && (x86 || COMPILE_TEST)
>
> Has this been tested?
> That should be X86
Right, it should be X86. It was cross-compile tested which was obviously not
enough. Thanks.
>
> > select MII
> > select PTP_1588_CLOCK_PCH
> > ---help---
> >
>
>
> --
> ~Randy
prev parent reply other threads:[~2013-09-10 2:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 19:28 [PATCH] pch_gbe: fix unmet direct dependency on PTP_1588_CLOCK_PCH Vladimir Murzin
2013-09-09 20:00 ` Randy Dunlap
2013-09-10 2:29 ` Vladimir Murzin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130910022936.GA3630@hp530 \
--to=murzin.v@gmail.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=haicheng.lee@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).