* [PATCH] pch_gbe: fix unmet direct dependency on PTP_1588_CLOCK_PCH
@ 2013-09-09 19:28 Vladimir Murzin
2013-09-09 20:00 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Murzin @ 2013-09-09 19:28 UTC (permalink / raw)
To: netdev
Cc: davem, ben, jeffrey.t.kirsher, rdunlap, haicheng.lee,
Vladimir Murzin
While cross-building for PPC.
warning: (PCH_GBE) selects PTP_1588_CLOCK_PCH which has unmet direct
dependencies (X86 || COMPILE_TEST)
Both PCH_GBE and PPT_1588_CLOCK_PCH is only compatible with Intel
architecture. Add dependency on x86 for PCH_GBE. Keep COMPILE_TEST to allow
building on different arches.
Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
---
drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
index cb22341..4a935ec 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
@@ -4,7 +4,7 @@
config PCH_GBE
tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
- depends on PCI
+ depends on PCI && (x86 || COMPILE_TEST)
select MII
select PTP_1588_CLOCK_PCH
---help---
--
1.8.1.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pch_gbe: fix unmet direct dependency on PTP_1588_CLOCK_PCH
2013-09-09 19:28 [PATCH] pch_gbe: fix unmet direct dependency on PTP_1588_CLOCK_PCH Vladimir Murzin
@ 2013-09-09 20:00 ` Randy Dunlap
2013-09-10 2:29 ` Vladimir Murzin
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2013-09-09 20:00 UTC (permalink / raw)
To: Vladimir Murzin
Cc: netdev, davem, ben, jeffrey.t.kirsher, rdunlap, haicheng.lee
On 09/09/13 12:28, Vladimir Murzin wrote:
> While cross-building for PPC.
>
> warning: (PCH_GBE) selects PTP_1588_CLOCK_PCH which has unmet direct
> dependencies (X86 || COMPILE_TEST)
>
> Both PCH_GBE and PPT_1588_CLOCK_PCH is only compatible with Intel
> architecture. Add dependency on x86 for PCH_GBE. Keep COMPILE_TEST to allow
> building on different arches.
>
> Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
> ---
> drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> index cb22341..4a935ec 100644
> --- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> +++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> @@ -4,7 +4,7 @@
>
> config PCH_GBE
> tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
> - depends on PCI
> + depends on PCI && (x86 || COMPILE_TEST)
Has this been tested?
That should be X86
> select MII
> select PTP_1588_CLOCK_PCH
> ---help---
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pch_gbe: fix unmet direct dependency on PTP_1588_CLOCK_PCH
2013-09-09 20:00 ` Randy Dunlap
@ 2013-09-10 2:29 ` Vladimir Murzin
0 siblings, 0 replies; 3+ messages in thread
From: Vladimir Murzin @ 2013-09-10 2:29 UTC (permalink / raw)
To: Randy Dunlap; +Cc: netdev, davem, ben, jeffrey.t.kirsher, rdunlap, haicheng.lee
On Mon, Sep 09, 2013 at 01:00:37PM -0700, Randy Dunlap wrote:
> On 09/09/13 12:28, Vladimir Murzin wrote:
> > While cross-building for PPC.
> >
> > warning: (PCH_GBE) selects PTP_1588_CLOCK_PCH which has unmet direct
> > dependencies (X86 || COMPILE_TEST)
> >
> > Both PCH_GBE and PPT_1588_CLOCK_PCH is only compatible with Intel
> > architecture. Add dependency on x86 for PCH_GBE. Keep COMPILE_TEST to allow
> > building on different arches.
> >
> > Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
> > ---
> > drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> > index cb22341..4a935ec 100644
> > --- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> > +++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> > @@ -4,7 +4,7 @@
> >
> > config PCH_GBE
> > tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
> > - depends on PCI
> > + depends on PCI && (x86 || COMPILE_TEST)
>
> Has this been tested?
> That should be X86
Right, it should be X86. It was cross-compile tested which was obviously not
enough. Thanks.
>
> > select MII
> > select PTP_1588_CLOCK_PCH
> > ---help---
> >
>
>
> --
> ~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-10 2:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-09 19:28 [PATCH] pch_gbe: fix unmet direct dependency on PTP_1588_CLOCK_PCH Vladimir Murzin
2013-09-09 20:00 ` Randy Dunlap
2013-09-10 2:29 ` Vladimir Murzin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).