netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net_sched: htb: fix a typo in htb_change_class()
@ 2013-09-11  0:36 Eric Dumazet
  2013-09-11  5:58 ` Jiri Pirko
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2013-09-11  0:36 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, Jesper Dangaard Brouer, Vimalkumar, Jiri Pirko

From: Vimalkumar <j.vimal@gmail.com>

Fix a typo added in commit 56b765b79 ("htb: improved accuracy at high
rates")

cbuffer should not be a copy of buffer.

Signed-off-by: Vimalkumar <j.vimal@gmail.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Jiri Pirko <jpirko@redhat.com>
---
 net/sched/sch_htb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
index c2178b1..863846c 100644
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c
@@ -1495,7 +1495,7 @@ static int htb_change_class(struct Qdisc *sch, u32 classid,
 	psched_ratecfg_precompute(&cl->ceil, &hopt->ceil);
 
 	cl->buffer = PSCHED_TICKS2NS(hopt->buffer);
-	cl->cbuffer = PSCHED_TICKS2NS(hopt->buffer);
+	cl->cbuffer = PSCHED_TICKS2NS(hopt->cbuffer);
 
 	sch_tree_unlock(sch);
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net_sched: htb: fix a typo in htb_change_class()
  2013-09-11  0:36 [PATCH] net_sched: htb: fix a typo in htb_change_class() Eric Dumazet
@ 2013-09-11  5:58 ` Jiri Pirko
  2013-09-11 21:17   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Jiri Pirko @ 2013-09-11  5:58 UTC (permalink / raw)
  To: Eric Dumazet
  Cc: David Miller, netdev, Jesper Dangaard Brouer, Vimalkumar,
	Jiri Pirko

Wed, Sep 11, 2013 at 02:36:37AM CEST, eric.dumazet@gmail.com wrote:
>From: Vimalkumar <j.vimal@gmail.com>
>
>Fix a typo added in commit 56b765b79 ("htb: improved accuracy at high
>rates")
>
>cbuffer should not be a copy of buffer.
>
>Signed-off-by: Vimalkumar <j.vimal@gmail.com>
>Signed-off-by: Eric Dumazet <edumazet@google.com>
>Cc: Jesper Dangaard Brouer <brouer@redhat.com>
>Cc: Jiri Pirko <jpirko@redhat.com>
Reviewed-by: Jiri Pirko <jiri@resnulli.us>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net_sched: htb: fix a typo in htb_change_class()
  2013-09-11  5:58 ` Jiri Pirko
@ 2013-09-11 21:17   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-09-11 21:17 UTC (permalink / raw)
  To: jiri; +Cc: eric.dumazet, netdev, brouer, j.vimal, jpirko

From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 11 Sep 2013 07:58:27 +0200

> Wed, Sep 11, 2013 at 02:36:37AM CEST, eric.dumazet@gmail.com wrote:
>>From: Vimalkumar <j.vimal@gmail.com>
>>
>>Fix a typo added in commit 56b765b79 ("htb: improved accuracy at high
>>rates")
>>
>>cbuffer should not be a copy of buffer.
>>
>>Signed-off-by: Vimalkumar <j.vimal@gmail.com>
>>Signed-off-by: Eric Dumazet <edumazet@google.com>
>>Cc: Jesper Dangaard Brouer <brouer@redhat.com>
>>Cc: Jiri Pirko <jpirko@redhat.com>
> Reviewed-by: Jiri Pirko <jiri@resnulli.us>

Applied and queued up for -stable, thanks everyone.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-11 21:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11  0:36 [PATCH] net_sched: htb: fix a typo in htb_change_class() Eric Dumazet
2013-09-11  5:58 ` Jiri Pirko
2013-09-11 21:17   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).