From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, vfalico@redhat.com, nhorman@redhat.com,
fubar@us.ibm.com, andy@greyhouse.net
Subject: Re: [PATCH v2] bonding: Make alb learning packet interval configurable
Date: Thu, 12 Sep 2013 16:49:48 -0400 (EDT) [thread overview]
Message-ID: <20130912.164948.1364121695106020281.davem@davemloft.net> (raw)
In-Reply-To: <1378845543-14876-1-git-send-email-nhorman@tuxdriver.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Tue, 10 Sep 2013 16:39:03 -0400
> From: Neil Horman <nhorman@redhat.com>
>
> running bonding in ALB mode requires that learning packets be sent periodically,
> so that the switch knows where to send responding traffic. However, depending
> on switch configuration, there may not be any need to send traffic at the
> default rate of 3 packets per second, which represents little more than wasted
> data. Allow the ALB learning packet interval to be made configurable via sysfs
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
I hate to be a stickler, but I'd like you to make the default value
documented both in the code and in the documentation.
Use some macro for the code "#define BOND_ALB_DEFAULT_LP_INTERVAL 1" and
mention the default in the bonding.txt changes.
Thanks.
next prev parent reply other threads:[~2013-09-12 20:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 14:14 [PATCH] bonding: Make alb learning packet interval configurable Neil Horman
2013-09-10 18:11 ` Veaceslav Falico
2013-09-10 19:04 ` Neil Horman
2013-09-10 20:39 ` [PATCH v2] " Neil Horman
2013-09-10 20:55 ` Veaceslav Falico
2013-09-12 20:49 ` David Miller [this message]
2013-09-12 21:06 ` Andy Gospodarek
2013-09-13 3:01 ` Neil Horman
2013-09-13 15:05 ` [PATCH v3] " Neil Horman
2013-09-13 15:38 ` Andy Gospodarek
2013-09-16 4:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912.164948.1364121695106020281.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=nhorman@tuxdriver.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).