Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: B38611@freescale.com
Cc: shawn.guo@linaro.org, netdev@vger.kernel.org,
	bhutchings@solarflare.com, stephen@networkplumber.org,
	b20596@freescale.com, s.hauer@pengutronix.de
Subject: Re: [PATCH v2 1/1] net: fec: fix phy reset operation to let imx6sl evk work
Date: Thu, 12 Sep 2013 17:12:51 -0400 (EDT)	[thread overview]
Message-ID: <20130912.171251.883636431449078988.davem@davemloft.net> (raw)
In-Reply-To: <1378865937-12055-1-git-send-email-B38611@freescale.com>

From: Fugang Duan <B38611@freescale.com>
Date: Wed, 11 Sep 2013 10:18:57 +0800

> Current driver only do phy reset in probe function, which is
> not right. Since some phy clock is disabled after module probe,
> the phy enter abnormal status, which needs do reset to recovery
> the phy. And do ifconfig ethx up/down test, the phy also enter
> abnormal status.

What would disable the PHY clock after the probe?

You have to explain these kinds of things in your changelog
message.

Thanks.

  reply	other threads:[~2013-09-12 21:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11  2:18 [PATCH v2 1/1] net: fec: fix phy reset operation to let imx6sl evk work Fugang Duan
2013-09-12 21:12 ` David Miller [this message]
2013-09-13  1:37   ` Duan Fugang-B38611

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130912.171251.883636431449078988.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=B38611@freescale.com \
    --cc=b20596@freescale.com \
    --cc=bhutchings@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox