From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 7/7] sysfs: @name comes before @ns Date: Wed, 11 Sep 2013 23:49:43 -0400 Message-ID: <20130912034943.GB4723@mtj.dyndns.org> References: <1378952949-7900-1-git-send-email-tj@kernel.org> <1378952949-7900-8-git-send-email-tj@kernel.org> <87a9ji4sk0.fsf@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, kay@vrfy.org, netdev@vger.kernel.org, lizefan@huawei.com To: "Eric W. Biederman" Return-path: Content-Disposition: inline In-Reply-To: <87a9ji4sk0.fsf@xmission.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello, Eric. On Wed, Sep 11, 2013 at 08:39:27PM -0700, Eric W. Biederman wrote: > @ns is more significant so it should come first. > > Where do we have the backwards convention of putting @name first? Because @ns is optional and you end up with stupid stuff like sysfs_xxx_ns(@param, @ns, @name) sysfs_xxx(@param, @name) You put optional params after the mandatory ones. It may be difficult to accept for you but @ns is a *clearly* optional thing for sysfs. -- tejun