From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, jeffm@suse.com, isdn4linux@koppen.de,
isdn@linux-pingi.de, jslaby@suse.cz,
sergei.shtylyov@cogentembedded.com
Subject: Re: [patch 2/4] mISDN: add support for group membership check
Date: Fri, 13 Sep 2013 20:00:19 -0400 (EDT) [thread overview]
Message-ID: <20130913.200019.1803722327800834566.davem@davemloft.net> (raw)
In-Reply-To: <20130913215202.7D16C31C1BF@corp2gmr1-1.hot.corp.google.com>
From: akpm@linux-foundation.org
Date: Fri, 13 Sep 2013 14:52:02 -0700
> @@ -612,6 +612,11 @@ data_sock_create(struct net *net, struct
> {
> struct sock *sk;
>
> + if (!capable(CAP_SYS_ADMIN) &&
> + !gid_eq(misdn_permitted_gid, current_gid()) &&
> + !in_group_p(misdn_permitted_gid))
> + return -EPERM;
This and the other conditional need to be styled correctly:
if (a &&
b &&
c)
the object is to get the second and subsequent lines to start at the
first column after the openning parenthesis of the condition, using
the appropriate number of tab and space characters.
next prev parent reply other threads:[~2013-09-14 0:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 21:52 [patch 2/4] mISDN: add support for group membership check akpm
2013-09-14 0:00 ` David Miller [this message]
2013-09-14 23:28 ` Ben Hutchings
2013-09-20 13:44 ` Jiri Slaby
2013-09-20 15:56 ` David Miller
2013-09-20 16:14 ` Jiri Slaby
2013-09-20 16:15 ` David Miller
2013-09-20 16:18 ` Jiri Slaby
2013-09-20 16:21 ` David Miller
2013-09-20 16:30 ` Jiri Slaby
2013-09-21 15:36 ` Karsten Keil
2013-09-20 16:30 ` Ben Hutchings
2013-09-20 17:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913.200019.1803722327800834566.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=isdn4linux@koppen.de \
--cc=isdn@linux-pingi.de \
--cc=jeffm@suse.com \
--cc=jslaby@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).