* [PATCH] [Trivial] remove unnecessary header file inclusion
@ 2013-09-13 14:57 ZHAO Gang
2013-09-13 16:11 ` Ben Hutchings
2013-09-13 21:48 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: ZHAO Gang @ 2013-09-13 14:57 UTC (permalink / raw)
To: gamerh2o; +Cc: davem, netdev, linux-kernel
file linux/fib_rules.h doesn't exist, so remove it.
Signed-off-by: ZHAO Gang <gamerh2o@gmail.com>
---
include/net/fib_rules.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/net/fib_rules.h b/include/net/fib_rules.h
index 4b2b557..c816f91 100644
--- a/include/net/fib_rules.h
+++ b/include/net/fib_rules.h
@@ -4,7 +4,6 @@
#include <linux/types.h>
#include <linux/slab.h>
#include <linux/netdevice.h>
-#include <linux/fib_rules.h>
#include <net/flow.h>
#include <net/rtnetlink.h>
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [Trivial] remove unnecessary header file inclusion
2013-09-13 14:57 [PATCH] [Trivial] remove unnecessary header file inclusion ZHAO Gang
@ 2013-09-13 16:11 ` Ben Hutchings
2013-09-13 21:48 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Ben Hutchings @ 2013-09-13 16:11 UTC (permalink / raw)
To: ZHAO Gang; +Cc: davem, netdev, linux-kernel
On Fri, 2013-09-13 at 22:57 +0800, ZHAO Gang wrote:
> file linux/fib_rules.h doesn't exist, so remove it.
Do you think people wouldn't notice #include of a nonexistent file? gcc
is quite good at complaining about them...
It's now called include/uapi/linux/fib_rules.h.
Ben.
> Signed-off-by: ZHAO Gang <gamerh2o@gmail.com>
> ---
> include/net/fib_rules.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/net/fib_rules.h b/include/net/fib_rules.h
> index 4b2b557..c816f91 100644
> --- a/include/net/fib_rules.h
> +++ b/include/net/fib_rules.h
> @@ -4,7 +4,6 @@
> #include <linux/types.h>
> #include <linux/slab.h>
> #include <linux/netdevice.h>
> -#include <linux/fib_rules.h>
> #include <net/flow.h>
> #include <net/rtnetlink.h>
>
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [Trivial] remove unnecessary header file inclusion
2013-09-13 14:57 [PATCH] [Trivial] remove unnecessary header file inclusion ZHAO Gang
2013-09-13 16:11 ` Ben Hutchings
@ 2013-09-13 21:48 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-09-13 21:48 UTC (permalink / raw)
To: gamerh2o; +Cc: netdev, linux-kernel
From: ZHAO Gang <gamerh2o@gmail.com>
Date: Fri, 13 Sep 2013 22:57:18 +0800
>
> file linux/fib_rules.h doesn't exist, so remove it.
Oh yes it does.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-13 21:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-13 14:57 [PATCH] [Trivial] remove unnecessary header file inclusion ZHAO Gang
2013-09-13 16:11 ` Ben Hutchings
2013-09-13 21:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).