* [PATCH 1/1] isdn: hfcpci_softirq: get func return to suppress compiler warning
@ 2013-09-14 17:20 Antonio Alecrim Jr
2013-09-16 4:53 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Antonio Alecrim Jr @ 2013-09-14 17:20 UTC (permalink / raw)
To: Karsten Keil, Masanari Iida, netdev, linux-kernel; +Cc: Antonio Alecrim Jr
Signed-off-by: Antonio Alecrim Jr <antonio.alecrim@gmail.com>
---
drivers/isdn/hardware/mISDN/hfcpci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
index 7f910c7..3c92780 100644
--- a/drivers/isdn/hardware/mISDN/hfcpci.c
+++ b/drivers/isdn/hardware/mISDN/hfcpci.c
@@ -2295,8 +2295,8 @@ _hfcpci_softirq(struct device *dev, void *arg)
static void
hfcpci_softirq(void *arg)
{
- (void) driver_for_each_device(&hfc_driver.driver, NULL, arg,
- _hfcpci_softirq);
+ WARN_ON_ONCE(driver_for_each_device(&hfc_driver.driver, NULL, arg,
+ _hfcpci_softirq) != 0);
/* if next event would be in the past ... */
if ((s32)(hfc_jiffies + tics - jiffies) <= 0)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 1/1] isdn: hfcpci_softirq: get func return to suppress compiler warning
@ 2013-09-13 17:44 Antonio Alecrim Jr
2013-09-13 21:07 ` Ben Hutchings
0 siblings, 1 reply; 4+ messages in thread
From: Antonio Alecrim Jr @ 2013-09-13 17:44 UTC (permalink / raw)
To: Karsten Keil, Masanari Iida, netdev, linux-kernel; +Cc: Antonio Alecrim Jr
Signed-off-by: Antonio Alecrim Jr <antonio.alecrim@gmail.com>
---
drivers/isdn/hardware/mISDN/hfcpci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
index 7f910c7..5b8df75b 100644
--- a/drivers/isdn/hardware/mISDN/hfcpci.c
+++ b/drivers/isdn/hardware/mISDN/hfcpci.c
@@ -2295,7 +2295,9 @@ _hfcpci_softirq(struct device *dev, void *arg)
static void
hfcpci_softirq(void *arg)
{
- (void) driver_for_each_device(&hfc_driver.driver, NULL, arg,
+ int ret;
+
+ ret = driver_for_each_device(&hfc_driver.driver, NULL, arg,
_hfcpci_softirq);
/* if next event would be in the past ... */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] isdn: hfcpci_softirq: get func return to suppress compiler warning
2013-09-13 17:44 Antonio Alecrim Jr
@ 2013-09-13 21:07 ` Ben Hutchings
0 siblings, 0 replies; 4+ messages in thread
From: Ben Hutchings @ 2013-09-13 21:07 UTC (permalink / raw)
To: Antonio Alecrim Jr; +Cc: Karsten Keil, Masanari Iida, netdev, linux-kernel
On Fri, 2013-09-13 at 14:44 -0300, Antonio Alecrim Jr wrote:
> Signed-off-by: Antonio Alecrim Jr <antonio.alecrim@gmail.com>
> ---
> drivers/isdn/hardware/mISDN/hfcpci.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
> index 7f910c7..5b8df75b 100644
> --- a/drivers/isdn/hardware/mISDN/hfcpci.c
> +++ b/drivers/isdn/hardware/mISDN/hfcpci.c
> @@ -2295,7 +2295,9 @@ _hfcpci_softirq(struct device *dev, void *arg)
> static void
> hfcpci_softirq(void *arg)
> {
> - (void) driver_for_each_device(&hfc_driver.driver, NULL, arg,
> + int ret;
> +
> + ret = driver_for_each_device(&hfc_driver.driver, NULL, arg,
> _hfcpci_softirq);
>
> /* if next event would be in the past ... */
This can result in a new compiler warning because ret is not used after
it is assigned. Maybe add WARN_ON(ret)?
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-16 4:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-14 17:20 [PATCH 1/1] isdn: hfcpci_softirq: get func return to suppress compiler warning Antonio Alecrim Jr
2013-09-16 4:53 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2013-09-13 17:44 Antonio Alecrim Jr
2013-09-13 21:07 ` Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).