From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net loopback: Set loopback_dev to NULL when freed Date: Mon, 16 Sep 2013 21:34:35 -0400 (EDT) Message-ID: <20130916.213435.1508866100258405440.davem@davemloft.net> References: <87k3iggw8m.fsf_-_@xmission.com> <1379379051.4751.0.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: ebiederm@xmission.com, edumazet@google.com, jiri@resnulli.us, alexander.h.duyck@intel.com, amwang@redhat.com, netdev@vger.kernel.org, fruggeri@aristanetworks.com To: eric.dumazet@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:43719 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751437Ab3IQBeh (ORCPT ); Mon, 16 Sep 2013 21:34:37 -0400 In-Reply-To: <1379379051.4751.0.camel@edumazet-glaptop> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Mon, 16 Sep 2013 17:50:51 -0700 > On Mon, 2013-09-16 at 16:52 -0700, Eric W. Biederman wrote: >> It has recently turned up that we have a number of long standing bugs >> in the network stack cleanup code with use of the loopback device >> after it has been freed that have not turned up because in most cases >> the storage allocated to the loopback device is not reused, when those >> accesses happen. >> >> Set looback_dev to NULL to trigger oopses instead of silent data corrupt >> when we hit this class of bug. >> >> Signed-off-by: "Eric W. Biederman" >> --- > > Acked-by: Eric Dumazet I'd like to apply this to 'net', any objections?