From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thadeu Lima de Souza Cascardo Subject: Re: [patch 1/4] drivers/net/ethernet/ibm/ehea/ehea_main.c: add alias entry for portN properties Date: Mon, 16 Sep 2013 17:55:43 -0300 Message-ID: <20130916205543.GA14221@oc0268524204.ibm.com> References: <20130913215201.6501131C1BF@corp2gmr1-1.hot.corp.google.com> <20130913.195857.1842211951469893139.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, netdev@vger.kernel.org, ohering@suse.com, jeffm@suse.com, jslaby@suse.cz To: David Miller Return-path: Received: from e24smtp02.br.ibm.com ([32.104.18.86]:40532 "EHLO e24smtp02.br.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951Ab3IPUzw (ORCPT ); Mon, 16 Sep 2013 16:55:52 -0400 Received: from /spool/local by e24smtp02.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Sep 2013 17:55:50 -0300 Received: from d24relay03.br.ibm.com (d24relay03.br.ibm.com [9.13.184.25]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id 1F9B71DC006D for ; Mon, 16 Sep 2013 16:55:47 -0400 (EDT) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay03.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8GKsDh943516058 for ; Mon, 16 Sep 2013 17:54:13 -0300 Received: from d24av04.br.ibm.com (localhost [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r8GKtkT3017887 for ; Mon, 16 Sep 2013 17:55:46 -0300 Content-Disposition: inline In-Reply-To: <20130913.195857.1842211951469893139.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Sep 13, 2013 at 07:58:57PM -0400, David Miller wrote: > From: akpm@linux-foundation.org > Date: Fri, 13 Sep 2013 14:52:01 -0700 > > > From: Olaf Hering > > Subject: drivers/net/ethernet/ibm/ehea/ehea_main.c: add alias entry for portN properties > > > > Use separate table for alias entries in the ehea module, otherwise the > > probe() function will operate on the separate ports instead of the > > lhea-"root" entry of the device-tree > > > > Addresses https://bugzilla.novell.com/show_bug.cgi?id=435215 > > > > Signed-off-by: Jeff Mahoney > > Signed-off-by: Olaf Hering > > Signed-off-by: Jiri Slaby > > Cc: Thadeu Lima de Souza Cascardo > > Cc: "David S. Miller" > > Signed-off-by: Andrew Morton > > This can definitely have consequences and in particular potentially cause > a device to not get probed properly. > > Therefore I want an ehea driver maintainer to review and ACK this before > I apply it. > > Thanks. > After taking a glance at the patch, it doesn't seem to change probing, since it keeps the same table for the driver itself. It seems this only changes alias, so the driver will be loaded under some device-tree layouts not currently matched by the current alias. That last part is the one that bothers me. I still need to find a system where the current modalias won't work and this patch is needed. I'll see if I can put more effort into that and find a system as described in the bug. Regards. Thadeu Cascardo.