From: David Miller <davem@davemloft.net>
To: paul.durrant@citrix.com
Cc: xen-devel@lists.xen.org, netdev@vger.kernel.org,
david.vrabel@citrix.com, wei.liu2@citrix.com,
ian.campbell@citrix.com
Subject: Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down
Date: Tue, 17 Sep 2013 20:30:56 -0400 (EDT) [thread overview]
Message-ID: <20130917.203056.560938568772547630.davem@davemloft.net> (raw)
In-Reply-To: <1379436368-6882-1-git-send-email-paul.durrant@citrix.com>
From: Paul Durrant <paul.durrant@citrix.com>
Date: Tue, 17 Sep 2013 17:46:08 +0100
> Without this patch, if a frontend cycles through states Closing
> and Closed (which Windows frontends need to do) then the netdev
> will be destroyed and requires re-invocation of hotplug scripts
> to restore state before the frontend can move to Connected. Thus
> when udev is not in use the backend gets stuck in InitWait.
>
> With this patch, the netdev is left alone whilst the backend is
> still online and is only de-registered and freed just prior to
> destroying the vif (which is also nicely symmetrical with the
> netdev allocation and registration being done during probe) so
> no re-invocation of hotplug scripts is required.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Can a xen driver expert please review and give an Acked-by:?
Thanks.
next prev parent reply other threads:[~2013-09-18 0:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 16:46 [PATCH net-next v4] Don't destroy the netdev until the vif is shut down Paul Durrant
2013-09-18 0:30 ` David Miller [this message]
2013-09-18 10:37 ` Wei Liu
2013-09-18 15:58 ` Ian Campbell
2013-09-18 16:04 ` Paul Durrant
2013-09-18 16:25 ` Ian Campbell
2013-09-19 11:55 ` Paul Durrant
2013-09-19 18:05 ` David Miller
2013-09-20 8:10 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917.203056.560938568772547630.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).