From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2 1/2] ipv4: IP_TOS and IP_TTL can be specified as ancillary data Date: Tue, 17 Sep 2013 20:46:48 -0400 (EDT) Message-ID: <20130917.204648.339747836268253489.davem@davemloft.net> References: <20130827.145649.1682045616049011855.davem@davemloft.net> <521DAD30.1010903@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: ffusco@redhat.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:45656 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741Ab3IRAqu (ORCPT ); Tue, 17 Sep 2013 20:46:50 -0400 In-Reply-To: <521DAD30.1010903@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Francesco Fusco Date: Wed, 28 Aug 2013 09:56:32 +0200 > On 08/27/2013 08:56 PM, David Miller wrote: >> From: Francesco Fusco >> Date: Fri, 23 Aug 2013 14:19:32 +0200 >> >>> - changed the icmp_cookie ttl field from __s16 to __u8. >>> A value of 0 means that the TTL has not been specified >> >> Sorry, I have to ask you to change the ttl field type back to __s16 >> and use "-1" to mean not-specified. >> >> Zero is a valid TTL setting and it means to not allow the >> packet to leave this host. > > Actually setsockopt() does not allow a TTL value of zero: > > From net/ipv4/ip_sockglue.c::do_ip_setsockopt() Indeed, you are right. Please resubmit these patches for the next merge window. Thank you.