From: Stephen Hemminger <stephen@networkplumber.org>
To: Hong Zhiguo <honkiko@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
eric.dumazet@gmail.com, vyasevic@redhat.com,
Hong Zhiguo <zhiguohong@tencent.com>
Subject: Re: [PATCH net-next] bridge: change the order of actions in addif/delif
Date: Tue, 17 Sep 2013 09:24:08 -0700 [thread overview]
Message-ID: <20130917092408.19a329b2@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1379403883-16219-1-git-send-email-zhiguohong@tencent.com>
On Tue, 17 Sep 2013 15:44:43 +0800
Hong Zhiguo <honkiko@gmail.com> wrote:
> - /* Device is already being bridged */
> - if (br_port_exists(dev))
> + /* Device is already being bridged or registered with other handler */
> + if (br_port_exists(dev) || dev->rx_handler)
> return -EBUSY;
Direct access to dev->rx_handler should be avoided.
The error check should be in netdev_rx_handler_register.
prev parent reply other threads:[~2013-09-17 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 7:44 [PATCH net-next] bridge: change the order of actions in addif/delif Hong Zhiguo
2013-09-17 11:57 ` Eric Dumazet
2013-09-17 16:24 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917092408.19a329b2@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=honkiko@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
--cc=zhiguohong@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).