From: David Miller <davem@davemloft.net>
To: bjorn@mork.no
Cc: ming.lei@canonical.com, gregkh@linuxfoundation.org,
oneukum@suse.de, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, oliver@neukum.org
Subject: Re: [PATCH] USBNET: fix handling padding packet
Date: Wed, 18 Sep 2013 12:12:17 -0400 (EDT) [thread overview]
Message-ID: <20130918.121217.1293335702438057937.davem@davemloft.net> (raw)
In-Reply-To: <87zjra5dpx.fsf@nemi.mork.no>
From: Bjørn Mork <bjorn@mork.no>
Date: Wed, 18 Sep 2013 17:52:42 +0200
> Ming Lei <ming.lei@canonical.com> writes:
>
>> There is no reason to forbid DMA SG for one driver which requires
>> padding, right?
>
> Yes there is: Added complexity for everybody, based on a combination of
> features which just does not make any sense.
>
> No modern device should need the padding. No old device will be able to
> use the SG feature as implemented. You only enable it on USB3, don't
> you? If this feature is restricted to USB3 capable devices, then it most
> certainly can be restricted to ZLP capable devices with absolutely no
> difference in the resulting set of supported devices.
I completely agree.
next prev parent reply other threads:[~2013-09-18 16:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 9:10 [PATCH] USBNET: fix handling padding packet Ming Lei
[not found] ` <1379409002-7698-1-git-send-email-ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2013-09-18 0:33 ` David Miller
2013-09-18 13:46 ` Oliver Neukum
2013-09-18 13:59 ` Bjørn Mork
2013-09-18 15:09 ` Ming Lei
2013-09-18 15:52 ` Bjørn Mork
2013-09-18 16:12 ` David Miller [this message]
[not found] ` <87zjra5dpx.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2013-09-18 17:03 ` Ming Lei
2013-09-18 18:33 ` Bjørn Mork
2013-09-18 17:06 ` Oliver Neukum
2013-09-18 18:56 ` Bjørn Mork
2013-09-19 6:57 ` Oliver Neukum
[not found] ` <1379573843.8608.7.camel-B2T3B9s34ElbnMAlSieJcQ@public.gmane.org>
2013-09-19 7:18 ` Bjørn Mork
2013-09-19 8:29 ` David Laight
[not found] ` <87wqmd46vj.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2013-09-19 13:08 ` Ming Lei
[not found] ` <CACVXFVPOyr3eDrJxGhmoxDdZS2FL17qm6jv0ezDECUAk267jFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-11 14:26 ` David Laight
2013-09-18 15:43 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918.121217.1293335702438057937.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bjorn@mork.no \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).