From: Jacob Keller <jacob.e.keller@intel.com>
To: netdev@vger.kernel.org
Subject: [PATCH net RFC 0/2] net: BUG napi_disable sleep while atomic
Date: Wed, 18 Sep 2013 13:19:43 -0700 [thread overview]
Message-ID: <20130918201541.8697.3548.stgit@jekeller-desk1.amr.corp.intel.com> (raw)
The following series implements a fix for a possible sleep while atomic bug in
the ixgbe driver, caused because napi_disable might sleep. The first patch adds
a might_sleep() call in order to make future sleep while atomic bugs easier to
discover, (as napi_disable does not always sleep!). The second patch is my best
guess at an actual fix for the bug. There is likely a similar bug in every
driver which implemented NET_RX_BUSY_POLL similar to ixgbe. The first patch
will likely cause BUG splats to appear in those drivers unless they are fixed.
---
Jacob Keller (2):
netdevice: add might_sleep() call to napi_disable
ixgbe: fix sleep bug caused by napi_disable inside local_bh_disable()d context
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--
include/linux/netdevice.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
--
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
next reply other threads:[~2013-09-18 20:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 20:19 Jacob Keller [this message]
2013-09-18 20:20 ` [PATCH net RFC 1/2] netdevice: add might_sleep() call to napi_disable Jacob Keller
2013-10-08 12:39 ` Amir Vadai
2013-09-18 20:20 ` [PATCH net RFC 2/2] ixgbe: fix sleep bug caused by napi_disable inside local_bh_disable()d context Jacob Keller
2013-09-18 23:09 ` Francois Romieu
2013-09-18 23:24 ` Keller, Jacob E
2013-09-19 21:32 ` Francois Romieu
2013-09-19 22:28 ` Keller, Jacob E
2013-10-01 12:11 ` Yuval Mintz
2013-10-01 20:05 ` Keller, Jacob E
2013-10-01 20:08 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918201541.8697.3548.stgit@jekeller-desk1.amr.corp.intel.com \
--to=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox