From: David Miller <davem@davemloft.net>
To: djduanjiong@gmail.com
Cc: duanj.fnst@cn.fujitsu.com, netdev@vger.kernel.org
Subject: Re: [PATCH ] ipv6: handle the update of the NDISC_REDIRECT error code in icmpv6_err_convert
Date: Thu, 19 Sep 2013 14:02:49 -0400 (EDT) [thread overview]
Message-ID: <20130919.140249.933962101950748423.davem@davemloft.net> (raw)
In-Reply-To: <523A8A74.30005@gmail.com>
From: Duan Jiong <djduanjiong@gmail.com>
Date: Thu, 19 Sep 2013 13:24:04 +0800
> 于 2013/9/19 0:36, David Miller 写道:
>> From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
>> Date: Wed, 18 Sep 2013 20:04:48 +0800
>>
>>> From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
>>>
>>> when dealing with redirect message in udpv6_err() and
>>> rawv6_err() the err shoud be assigned to 0, not EPROTO.
>>>
>>> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
>> No, you should fix this the same way you handled DCCP, but skipping
>> the whole socket error setting path for NDISC_REDIRECT.
>
> Your meaning is that we should return directly after calling
> ip6_sk_redirect(), is that it?
It depends upon whether udp/raw sockets are expected to receive redirect
notifications this way, are they? You seem to believe so.
prev parent reply other threads:[~2013-09-19 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 12:04 [PATCH ] ipv6: handle the update of the NDISC_REDIRECT error code in icmpv6_err_convert Duan Jiong
2013-09-18 16:36 ` David Miller
2013-09-18 18:00 ` Hannes Frederic Sowa
2013-09-19 5:24 ` Duan Jiong
2013-09-19 18:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919.140249.933962101950748423.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=djduanjiong@gmail.com \
--cc=duanj.fnst@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).