* [PATCH 5/5] net: ethernet: eth.c: removed checkpatch warnings and errors
@ 2013-09-19 16:06 avi.kp.137
2013-09-20 18:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: avi.kp.137 @ 2013-09-19 16:06 UTC (permalink / raw)
To: davem; +Cc: akong, stefanha, jiri, netdev, linux-kernel, Avinash Kumar
From: Avinash Kumar <avi.kp.137@gmail.com>
removed these checkpatch.pl warnings:
net/ethernet/eth.c:61: WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
net/ethernet/eth.c:136: WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
net/ethernet/eth.c:181: ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>
---
net/ethernet/eth.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
index be1f64d..9bd3c31 100644
--- a/net/ethernet/eth.c
+++ b/net/ethernet/eth.c
@@ -58,7 +58,7 @@
#include <net/ipv6.h>
#include <net/ip.h>
#include <net/dsa.h>
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
__setup("ether=", netdev_boot_setup);
@@ -133,7 +133,7 @@ int eth_rebuild_header(struct sk_buff *skb)
return arp_find(eth->h_dest, skb);
#endif
default:
- printk(KERN_DEBUG
+ netdev_dbg(dev,
"%s: unable to resolve type %X addresses.\n",
dev->name, ntohs(eth->h_proto));
@@ -178,7 +178,7 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
* seems to set IFF_PROMISC.
*/
- else if (1 /*dev->flags&IFF_PROMISC */ ) {
+ else if (1 /*dev->flags&IFF_PROMISC */) {
if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
dev->dev_addr)))
skb->pkt_type = PACKET_OTHERHOST;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 5/5] net: ethernet: eth.c: removed checkpatch warnings and errors
2013-09-19 16:06 [PATCH 5/5] net: ethernet: eth.c: removed checkpatch warnings and errors avi.kp.137
@ 2013-09-20 18:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-09-20 18:42 UTC (permalink / raw)
To: avi.kp.137; +Cc: akong, stefanha, jiri, netdev, linux-kernel
From: avi.kp.137@gmail.com
Date: Thu, 19 Sep 2013 21:36:50 +0530
> From: Avinash Kumar <avi.kp.137@gmail.com>
>
> removed these checkpatch.pl warnings:
> net/ethernet/eth.c:61: WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
> net/ethernet/eth.c:136: WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
> net/ethernet/eth.c:181: ERROR: space prohibited before that close parenthesis ')'
>
> Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-20 18:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-19 16:06 [PATCH 5/5] net: ethernet: eth.c: removed checkpatch warnings and errors avi.kp.137
2013-09-20 18:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).