From: Ben Hutchings <ben@decadent.org.uk>
To: David Miller <davem@davemloft.net>
Cc: jslaby@suse.cz, akpm@linux-foundation.org, jeffm@suse.com,
netdev@vger.kernel.org, isdn4linux@koppen.de,
isdn@linux-pingi.de, sergei.shtylyov@cogentembedded.com
Subject: Re: [patch 2/4] mISDN: add support for group membership check
Date: Fri, 20 Sep 2013 17:30:44 +0100 [thread overview]
Message-ID: <20130920163043.GN7729@decadent.org.uk> (raw)
In-Reply-To: <20130920.122142.1032350399957506112.davem@davemloft.net>
On Fri, Sep 20, 2013 at 12:21:42PM -0400, David Miller wrote:
> From: Jiri Slaby <jslaby@suse.cz>
> Date: Fri, 20 Sep 2013 18:18:02 +0200
>
> > Ok, let's leave the hole in there then.
>
> Jiri, don't turn this on me.
>
> The issue is not whether something needs to be fixed or not, I never
> said "don't fix this" and therefore I'd like to ask politely that you
> not make it seem like I have.
>
> Rather, I'm saying that the implementation is terrible, sets a bad
> precendence for fixing similar problems, and therefore not is in
> a state where we can apply it.
>
> So, I'm not saying "don't fix this", I'm saying "fix it properly."
I think Jiri's last suggestion was to add the capability check to
device renaming (which I think everyone agrees is needed) and not
to add any group identity checks for any operation.
Isn't that fixing it properly?
Ben.
--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus
next prev parent reply other threads:[~2013-09-20 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 21:52 [patch 2/4] mISDN: add support for group membership check akpm
2013-09-14 0:00 ` David Miller
2013-09-14 23:28 ` Ben Hutchings
2013-09-20 13:44 ` Jiri Slaby
2013-09-20 15:56 ` David Miller
2013-09-20 16:14 ` Jiri Slaby
2013-09-20 16:15 ` David Miller
2013-09-20 16:18 ` Jiri Slaby
2013-09-20 16:21 ` David Miller
2013-09-20 16:30 ` Jiri Slaby
2013-09-21 15:36 ` Karsten Keil
2013-09-20 16:30 ` Ben Hutchings [this message]
2013-09-20 17:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920163043.GN7729@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=isdn4linux@koppen.de \
--cc=isdn@linux-pingi.de \
--cc=jeffm@suse.com \
--cc=jslaby@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).