netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH net-next 11/11] sfc: Add static tracepoints to datapath
Date: Mon, 23 Sep 2013 14:17:23 -0400 (EDT)	[thread overview]
Message-ID: <20130923.141723.230027899643613700.davem@davemloft.net> (raw)
In-Reply-To: <1379951467.2485.33.camel@bwh-desktop.uk.level5networks.com>

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 23 Sep 2013 16:51:07 +0100

> 2. Generic trace events would be subject to changes that could make them
> unsuitable for Solarflare's tests.

This is not an argument for doing things privately in your driver and
duplicating things.

We should make a facility that's useful to Solarflare _AS WELL AS_
everyone else.

> 4. Static tracepoints always have run-time overhead, so these should
> probably be controlled by a kconfig option (as in this patch).

Don't we use static branches and other tricks to make them close to zero
overhead?

  reply	other threads:[~2013-09-23 18:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-21 18:31 Pull request: sfc-next 2013-09-21 Ben Hutchings
2013-09-21 18:33 ` [PATCH net-next 01/11] sfc: efx_ethtool_get_ts_info() can be static Ben Hutchings
2013-09-21 18:33 ` [PATCH net-next 02/11] sfc: efx_ef10_filter_update_rx_scatter() " Ben Hutchings
2013-09-21 18:33 ` [PATCH net-next 03/11] sfc: Add EF10 registers to register dump Ben Hutchings
2013-09-21 18:34 ` [PATCH net-next 04/11] sfc: Fold tso_get_head_fragment() into tso_start() Ben Hutchings
2013-09-21 18:34 ` [PATCH net-next 05/11] sfc: Implement firmware-assisted TSO for EF10 Ben Hutchings
2013-09-21 18:34 ` [PATCH net-next 06/11] sfc: Allocate and link PIO buffers; map them with write-combining Ben Hutchings
2013-09-21 18:35 ` [PATCH net-next 07/11] sfc: Separate out queue-empty check from efx_nic_may_push_tx_desc() Ben Hutchings
2013-09-21 18:35 ` [PATCH net-next 08/11] sfc: Introduce inline functions to simplify TX insertion Ben Hutchings
2013-09-21 18:35 ` [PATCH net-next 09/11] sfc: Use TX PIO for sufficiently small packets Ben Hutchings
2013-09-21 18:36 ` [PATCH net-next 10/11] sfc: Support ARFS for IPv6 flows Ben Hutchings
2013-09-21 18:36 ` [PATCH net-next 11/11] sfc: Add static tracepoints to datapath Ben Hutchings
2013-09-23  6:08   ` David Miller
2013-09-23 15:51     ` Ben Hutchings
2013-09-23 18:17       ` David Miller [this message]
2013-09-23 18:34         ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130923.141723.230027899643613700.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=linux-net-drivers@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).