From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Whitehead Subject: Re: [net-next] Fix hardcoded interrupt name lp->name to use system device value Date: Sun, 22 Sep 2013 22:25:33 -0400 Message-ID: <20130923022532.GA17124@gmail.com> References: <1379789381-3992-1-git-send-email-thenaterhood@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org To: Nate Levesque Return-path: Received: from mail-qe0-f43.google.com ([209.85.128.43]:51756 "EHLO mail-qe0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752611Ab3IWCZl (ORCPT ); Sun, 22 Sep 2013 22:25:41 -0400 Received: by mail-qe0-f43.google.com with SMTP id gh4so1761493qeb.30 for ; Sun, 22 Sep 2013 19:25:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1379789381-3992-1-git-send-email-thenaterhood@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, Sep 21, 2013 at 06:49:41PM +0000, Nate Levesque wrote: > The lance interrupt handler was using the hard-coded name which would make it difficult to tell where the interrupt came from. Changed to use the device name that made the interrupt. > > Signed-off-by: Nate Levesque > --- > drivers/net/ethernet/amd/lance.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c > index 5c72843..256f590 100644 > --- a/drivers/net/ethernet/amd/lance.c > +++ b/drivers/net/ethernet/amd/lance.c > @@ -754,7 +754,7 @@ lance_open(struct net_device *dev) > int i; > > if (dev->irq == 0 || > - request_irq(dev->irq, lance_interrupt, 0, lp->name, dev)) { > + request_irq(dev->irq, lance_interrupt, 0, dev->name, dev)) { > return -EAGAIN; > } > > -- > 1.8.1.2 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Matthew Whitehead