* [net-next] Fix hardcoded interrupt name lp->name to use system device value
@ 2013-09-21 18:49 Nate Levesque
2013-09-23 2:25 ` Matthew Whitehead
0 siblings, 1 reply; 3+ messages in thread
From: Nate Levesque @ 2013-09-21 18:49 UTC (permalink / raw)
To: netdev; +Cc: Nate Levesque
The lance interrupt handler was using the hard-coded name which would make it difficult to tell where the interrupt came from. Changed to use the device name that made the interrupt.
Signed-off-by: Nate Levesque <thenaterhood@gmail.com>
---
drivers/net/ethernet/amd/lance.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c
index 5c72843..256f590 100644
--- a/drivers/net/ethernet/amd/lance.c
+++ b/drivers/net/ethernet/amd/lance.c
@@ -754,7 +754,7 @@ lance_open(struct net_device *dev)
int i;
if (dev->irq == 0 ||
- request_irq(dev->irq, lance_interrupt, 0, lp->name, dev)) {
+ request_irq(dev->irq, lance_interrupt, 0, dev->name, dev)) {
return -EAGAIN;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [net-next] Fix hardcoded interrupt name lp->name to use system device value
2013-09-21 18:49 [net-next] Fix hardcoded interrupt name lp->name to use system device value Nate Levesque
@ 2013-09-23 2:25 ` Matthew Whitehead
2013-09-27 21:40 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Whitehead @ 2013-09-23 2:25 UTC (permalink / raw)
To: Nate Levesque; +Cc: netdev
On Sat, Sep 21, 2013 at 06:49:41PM +0000, Nate Levesque wrote:
> The lance interrupt handler was using the hard-coded name which would make it difficult to tell where the interrupt came from. Changed to use the device name that made the interrupt.
>
> Signed-off-by: Nate Levesque <thenaterhood@gmail.com>
> ---
> drivers/net/ethernet/amd/lance.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c
> index 5c72843..256f590 100644
> --- a/drivers/net/ethernet/amd/lance.c
> +++ b/drivers/net/ethernet/amd/lance.c
> @@ -754,7 +754,7 @@ lance_open(struct net_device *dev)
> int i;
>
> if (dev->irq == 0 ||
> - request_irq(dev->irq, lance_interrupt, 0, lp->name, dev)) {
> + request_irq(dev->irq, lance_interrupt, 0, dev->name, dev)) {
> return -EAGAIN;
> }
>
> --
> 1.8.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Matthew Whitehead <tedheadster@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [net-next] Fix hardcoded interrupt name lp->name to use system device value
2013-09-23 2:25 ` Matthew Whitehead
@ 2013-09-27 21:40 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-09-27 21:40 UTC (permalink / raw)
To: tedheadster; +Cc: thenaterhood, netdev
From: Matthew Whitehead <tedheadster@gmail.com>
Date: Sun, 22 Sep 2013 22:25:33 -0400
> On Sat, Sep 21, 2013 at 06:49:41PM +0000, Nate Levesque wrote:
>> The lance interrupt handler was using the hard-coded name which would make it difficult to tell where the interrupt came from. Changed to use the device name that made the interrupt.
>>
>> Signed-off-by: Nate Levesque <thenaterhood@gmail.com>
>> ---
>> drivers/net/ethernet/amd/lance.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c
>> index 5c72843..256f590 100644
>> --- a/drivers/net/ethernet/amd/lance.c
>> +++ b/drivers/net/ethernet/amd/lance.c
>> @@ -754,7 +754,7 @@ lance_open(struct net_device *dev)
>> int i;
>>
>> if (dev->irq == 0 ||
>> - request_irq(dev->irq, lance_interrupt, 0, lp->name, dev)) {
>> + request_irq(dev->irq, lance_interrupt, 0, dev->name, dev)) {
>> return -EAGAIN;
>> }
>>
>> --
>> 1.8.1.2
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Reviewed-by: Matthew Whitehead <tedheadster@gmail.com>
Applied but please use a more appriate subsystem prefix in your Subject
lines, in this case you could say "lance: " after "[net-next] "
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-27 21:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-21 18:49 [net-next] Fix hardcoded interrupt name lp->name to use system device value Nate Levesque
2013-09-23 2:25 ` Matthew Whitehead
2013-09-27 21:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).