From: David Miller <davem@redhat.com>
To: hannes@stressinduktion.org
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] ipv6: udp packets following an UFO enqueued packet need also be handled by UFO
Date: Tue, 24 Sep 2013 11:43:44 -0400 (EDT) [thread overview]
Message-ID: <20130924.114344.932694780733009227.davem@redhat.com> (raw)
In-Reply-To: <20130921042700.GB8070@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Sat, 21 Sep 2013 06:27:00 +0200
> In the following scenario the socket is corked:
> If the first UDP packet is larger then the mtu we try to append it to the
> write queue via ip6_ufo_append_data. A following packet, which is smaller
> than the mtu would be appended to the already queued up gso-skb via
> plain ip6_append_data. This causes random memory corruptions.
>
> In ip6_ufo_append_data we also have to be careful to not queue up the
> same skb multiple times. So setup the gso frame only when no first skb
> is available.
>
> This also fixes a shortcoming where we add the current packet's length to
> cork->length but return early because of a packet > mtu with dontfrag set
> (instead of sutracting it again).
>
> Found with trinity.
>
> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2013-09-24 15:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 4:27 [PATCH] ipv6: udp packets following an UFO enqueued packet need also be handled by UFO Hannes Frederic Sowa
2013-09-23 0:43 ` Hannes Frederic Sowa
2013-09-24 15:43 ` David Miller [this message]
2013-09-30 11:43 ` Jiri Pirko
2013-09-30 17:23 ` Hannes Frederic Sowa
2013-10-01 10:58 ` Jiri Pirko
2013-10-01 12:09 ` Hannes Frederic Sowa
2013-10-01 12:32 ` Hannes Frederic Sowa
2013-10-01 21:47 ` Hannes Frederic Sowa
2013-10-01 23:25 ` Hannes Frederic Sowa
2013-10-02 8:58 ` Jiri Pirko
2013-10-02 10:41 ` Eric Dumazet
2013-10-02 12:12 ` Hannes Frederic Sowa
2013-10-02 13:03 ` Hannes Frederic Sowa
2013-10-02 15:14 ` Eric Dumazet
2013-10-02 16:27 ` Neterion and UFO handling [was: Re: [PATCH] ipv6: udp packets following an UFO enqueued packet need also be handled by UFO] Hannes Frederic Sowa
2013-10-07 16:53 ` Hannes Frederic Sowa
2013-10-07 17:19 ` Jon Mason
2013-10-07 17:27 ` Hannes Frederic Sowa
2013-10-08 8:07 ` Jon Mason
2013-10-08 13:00 ` Eric Dumazet
2013-10-08 14:53 ` Hannes Frederic Sowa
2013-10-17 4:45 ` Hannes Frederic Sowa
2013-10-18 7:52 ` Jiri Pirko
2013-10-23 16:35 ` Jon Mason
2013-10-23 18:15 ` Hannes Frederic Sowa
2013-10-02 10:33 ` [PATCH] ipv6: udp packets following an UFO enqueued packet need also be handled by UFO Jiri Pirko
2013-10-02 12:01 ` Hannes Frederic Sowa
2013-10-02 11:20 ` Jiri Pirko
2013-10-02 11:53 ` Eric Dumazet
2013-10-02 12:10 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924.114344.932694780733009227.davem@redhat.com \
--to=davem@redhat.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).