From: Stephen Hemminger <stephen@networkplumber.org>
To: Vincent Li <vincent.mc.li@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net
Subject: Re: [PATCH] Allow userspace code to use flag IFA_F_SECONDARY to specify an ip address to be primary or secondary ip on an interface
Date: Tue, 24 Sep 2013 12:21:01 -0700 [thread overview]
Message-ID: <20130924122101.6912dde0@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1380046281-6012-1-git-send-email-vincent.mc.li@gmail.com>
On Tue, 24 Sep 2013 11:11:21 -0700
Vincent Li <vincent.mc.li@gmail.com> wrote:
> - ifa->ifa_flags &= ~IFA_F_SECONDARY;
> last_primary = &in_dev->ifa_list;
>
> + if((*last_primary) == NULL)
Minor nit, paren's here are unnecessary
next prev parent reply other threads:[~2013-09-24 19:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 18:11 [PATCH] Allow userspace code to use flag IFA_F_SECONDARY to specify an ip address to be primary or secondary ip on an interface Vincent Li
2013-09-24 19:21 ` Stephen Hemminger [this message]
2013-09-24 19:28 ` David Miller
2013-09-24 20:46 ` Vincent Li
2013-09-24 21:13 ` Julian Anastasov
2013-09-24 21:34 ` Vincent Li
2013-09-24 21:54 ` Vincent Li
2013-09-25 7:08 ` Julian Anastasov
2013-09-25 17:30 ` Vincent Li
2013-09-27 19:26 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924122101.6912dde0@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vincent.mc.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox