From: Andy Gospodarek <andy@greyhouse.net>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Indenbaum <baum@tehutinetworks.net>
Subject: Re: question tehuti.c
Date: Tue, 24 Sep 2013 11:34:32 -0400 [thread overview]
Message-ID: <20130924153432.GI9773@gospo.rdu.redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1309231752040.2242@hadrien>
On Mon, Sep 23, 2013 at 05:54:00PM +0200, Julia Lawall wrote:
> The function bdx_setmulti in the file drivers/net/ethernet/tehuti/tehuti.c
> contains:
>
> u32 rxf_val =
> GMAC_RX_FILTER_AM | GMAC_RX_FILTER_AB | GMAC_RX_FILTER_OSEN;
>
> and then later:
>
> } else {
> DBG("only own mac %d\n", netdev_mc_count(ndev));
> rxf_val |= GMAC_RX_FILTER_AB;
> }
>
> The last assignment doesn't look very useful, because GMAC_RX_FILTER_ABis
> already included in rxf_val. Was something else intended?
You are correct that the setting of GMAC_RX_FILTER_AB is a bit redundant
since it was set earlier in the function.
I have not worked on this driver in several years and if there is no
response from Alexander or someone else at Tehuti Networks then you may
not get an answer to your question. :-/
prev parent reply other threads:[~2013-09-24 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 15:54 question tehuti.c Julia Lawall
2013-09-24 15:34 ` Andy Gospodarek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924153432.GI9773@gospo.rdu.redhat.com \
--to=andy@greyhouse.net \
--cc=baum@tehutinetworks.net \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox