From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: netdev@vger.kernel.org, greearb@candelatech.com, kaber@trash.net,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH net-next 2/2] ipv6: compare sernum when walking fib for /proc/net/ipv6_route as safety net
Date: Fri, 27 Sep 2013 17:33:13 -0400 (EDT) [thread overview]
Message-ID: <20130927.173313.1429984635743435628.davem@davemloft.net> (raw)
In-Reply-To: <20130921145610.GA20769@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Sat, 21 Sep 2013 16:56:10 +0200
> This patch provides an additional safety net against NULL
> pointer dereferences while walking the fib trie for the new
> /proc/net/ipv6_route walkers. I never needed it myself and am unsure
> if it is needed at all, but the same checks where introduced in
> 2bec5a369ee79576a3eea2c23863325089785a2c ("ipv6: fib: fix crash when
> changing large fib while dumping it") to fix NULL pointer bugs.
>
> This patch is separated from the first patch to make it easier to revert
> if we are sure we can drop this logic.
>
> Cc: Ben Greear <greearb@candelatech.com>
> Cc: Patrick McHardy <kaber@trash.net>
> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied.
prev parent reply other threads:[~2013-09-27 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 14:56 [PATCH net-next 2/2] ipv6: compare sernum when walking fib for /proc/net/ipv6_route as safety net Hannes Frederic Sowa
2013-09-27 21:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927.173313.1429984635743435628.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=hannes@stressinduktion.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).