* [net-next] hp100: replace hardcoded name in /proc/interrupts with interface name
@ 2013-09-21 18:48 Mihir Singh
2013-09-23 2:26 ` Matthew Whitehead
2013-09-27 21:39 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Mihir Singh @ 2013-09-21 18:48 UTC (permalink / raw)
To: netdev; +Cc: Mihir Singh
The /proc/interrupts file displays hp100, which is not the accepted style. Printing eth%d is more helpful.
Signed-off-by: Mihir Singh <me@mihirsingh.com>
---
drivers/net/ethernet/hp/hp100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hp/hp100.c b/drivers/net/ethernet/hp/hp100.c
index 91227d0..3786009 100644
--- a/drivers/net/ethernet/hp/hp100.c
+++ b/drivers/net/ethernet/hp/hp100.c
@@ -1098,7 +1098,7 @@ static int hp100_open(struct net_device *dev)
if (request_irq(dev->irq, hp100_interrupt,
lp->bus == HP100_BUS_PCI || lp->bus ==
HP100_BUS_EISA ? IRQF_SHARED : 0,
- "hp100", dev)) {
+ dev->name, dev)) {
printk("hp100: %s: unable to get IRQ %d\n", dev->name, dev->irq);
return -EAGAIN;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [net-next] hp100: replace hardcoded name in /proc/interrupts with interface name
2013-09-21 18:48 [net-next] hp100: replace hardcoded name in /proc/interrupts with interface name Mihir Singh
@ 2013-09-23 2:26 ` Matthew Whitehead
2013-09-27 21:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Whitehead @ 2013-09-23 2:26 UTC (permalink / raw)
To: Mihir Singh; +Cc: netdev
On Sat, Sep 21, 2013 at 06:48:09PM +0000, Mihir Singh wrote:
> The /proc/interrupts file displays hp100, which is not the accepted style. Printing eth%d is more helpful.
>
> Signed-off-by: Mihir Singh <me@mihirsingh.com>
> ---
> drivers/net/ethernet/hp/hp100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/hp/hp100.c b/drivers/net/ethernet/hp/hp100.c
> index 91227d0..3786009 100644
> --- a/drivers/net/ethernet/hp/hp100.c
> +++ b/drivers/net/ethernet/hp/hp100.c
> @@ -1098,7 +1098,7 @@ static int hp100_open(struct net_device *dev)
> if (request_irq(dev->irq, hp100_interrupt,
> lp->bus == HP100_BUS_PCI || lp->bus ==
> HP100_BUS_EISA ? IRQF_SHARED : 0,
> - "hp100", dev)) {
> + dev->name, dev)) {
> printk("hp100: %s: unable to get IRQ %d\n", dev->name, dev->irq);
> return -EAGAIN;
> }
> --
> 1.8.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-By: Matthew Whitehead <tedheadster@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [net-next] hp100: replace hardcoded name in /proc/interrupts with interface name
2013-09-21 18:48 [net-next] hp100: replace hardcoded name in /proc/interrupts with interface name Mihir Singh
2013-09-23 2:26 ` Matthew Whitehead
@ 2013-09-27 21:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-09-27 21:39 UTC (permalink / raw)
To: me; +Cc: netdev
From: Mihir Singh <me@mihirsingh.com>
Date: Sat, 21 Sep 2013 18:48:09 +0000
> The /proc/interrupts file displays hp100, which is not the accepted style. Printing eth%d is more helpful.
>
> Signed-off-by: Mihir Singh <me@mihirsingh.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-27 21:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-21 18:48 [net-next] hp100: replace hardcoded name in /proc/interrupts with interface name Mihir Singh
2013-09-23 2:26 ` Matthew Whitehead
2013-09-27 21:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).