netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, sesse@google.com, mtk.manpages@gmail.com
Subject: Re: [PATCH v2 net-next] net: introduce SO_MAX_PACING_RATE
Date: Sat, 28 Sep 2013 15:36:10 -0700 (PDT)	[thread overview]
Message-ID: <20130928.153610.2280100769720851440.davem@davemloft.net> (raw)
In-Reply-To: <1380036052.3165.71.camel@edumazet-glaptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 24 Sep 2013 08:20:52 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> As mentioned in commit afe4fd062416b ("pkt_sched: fq: Fair Queue packet
> scheduler"), this patch adds a new socket option.
> 
> SO_MAX_PACING_RATE offers the application the ability to cap the
> rate computed by transport layer. Value is in bytes per second.
> 
> u32 val = 1000000;
> setsockopt(sockfd, SOL_SOCKET, SO_MAX_PACING_RATE, &val, sizeof(val));
> 
> To be effectively paced, a flow must use FQ packet scheduler.
> 
> Note that a packet scheduler takes into account the headers for its
> computations. The effective payload rate depends on MSS and retransmits
> if any.
> 
> I chose to make this pacing rate a SOL_SOCKET option instead of a
> TCP one because this can be used by other protocols.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied, thanks Eric.

  reply	other threads:[~2013-09-28 22:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23 15:10 [PATCH net-next] net: introduce SO_MAX_PACING_RATE Eric Dumazet
2013-09-24 15:14 ` Eric Dumazet
2013-09-24 15:20 ` [PATCH v2 " Eric Dumazet
2013-09-28 22:36   ` David Miller [this message]
2013-09-29  8:12     ` [PATCH net-next] net: add missing sk_max_pacing_rate doc Eric Dumazet
2013-10-01  5:11       ` David Miller
2013-09-27 21:16 ` [PATCH net-next] net: introduce SO_MAX_PACING_RATE Steinar H. Gunderson
2013-09-28  0:28   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130928.153610.2280100769720851440.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=mtk.manpages@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=sesse@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).