netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: qmi_wwan: fix Cinterion PLXX product ID
@ 2013-09-25 15:02 Aleksander Morgado
       [not found] ` <1380121356-28601-1-git-send-email-aleksander-bhGbAngMcJvQT0dZR+AlfA@public.gmane.org>
  2013-09-26 14:02 ` Schmiedl Christian
  0 siblings, 2 replies; 4+ messages in thread
From: Aleksander Morgado @ 2013-09-25 15:02 UTC (permalink / raw)
  To: netdev, linux-usb
  Cc: davem, bjorn, dcbw, Aleksander Morgado, Hans-Christoph Schemmel,
	Christian Schmiedl, Nicolaus Colberg

Cinterion PLXX LTE devices have a 0x0060 product ID, not 0x12d1.

The blacklisting in the serial/option driver does actually use the correct PID,
as per commit 8ff10bdb14a52e3f25d4ce09e0582a8684c1a6db ('USB: Blacklisted
Cinterion's PLxx WWAN Interface').

CC: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
CC: Christian Schmiedl <christian.schmiedl@gemalto.com>
CC: Nicolaus Colberg <nicolaus.colberg@gemalto.com>
Signed-off-by: Aleksander Morgado <aleksander@lanedo.com>
---
 drivers/net/usb/qmi_wwan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 6312332..3d6aaf7 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -714,7 +714,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x2357, 0x0201, 4)},	/* TP-LINK HSUPA Modem MA180 */
 	{QMI_FIXED_INTF(0x2357, 0x9000, 4)},	/* TP-LINK MA260 */
 	{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)},	/* Telit LE920 */
-	{QMI_FIXED_INTF(0x1e2d, 0x12d1, 4)},	/* Cinterion PLxx */
+	{QMI_FIXED_INTF(0x1e2d, 0x0060, 4)},	/* Cinterion PLxx */
 
 	/* 4. Gobi 1000 devices */
 	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: qmi_wwan: fix Cinterion PLXX product ID
       [not found] ` <1380121356-28601-1-git-send-email-aleksander-bhGbAngMcJvQT0dZR+AlfA@public.gmane.org>
@ 2013-09-25 16:10   ` Bjørn Mork
  0 siblings, 0 replies; 4+ messages in thread
From: Bjørn Mork @ 2013-09-25 16:10 UTC (permalink / raw)
  To: Aleksander Morgado
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q, dcbw-H+wXaHxf7aLQT0dZR+AlfA,
	Hans-Christoph Schemmel, Christian Schmiedl, Nicolaus Colberg

Aleksander Morgado <aleksander-bhGbAngMcJvQT0dZR+AlfA@public.gmane.org> writes:

> Cinterion PLXX LTE devices have a 0x0060 product ID, not 0x12d1.
>
> The blacklisting in the serial/option driver does actually use the correct PID,
> as per commit 8ff10bdb14a52e3f25d4ce09e0582a8684c1a6db ('USB: Blacklisted
> Cinterion's PLxx WWAN Interface').

Right.  This seems like a typo.  Thanks

Acked-by: Bjørn Mork <bjorn-yOkvZcmFvRU@public.gmane.org>


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] net: qmi_wwan: fix Cinterion PLXX product ID
  2013-09-25 15:02 [PATCH] net: qmi_wwan: fix Cinterion PLXX product ID Aleksander Morgado
       [not found] ` <1380121356-28601-1-git-send-email-aleksander-bhGbAngMcJvQT0dZR+AlfA@public.gmane.org>
@ 2013-09-26 14:02 ` Schmiedl Christian
       [not found]   ` <376FB829F3ECB542B825EAF4D8CA8A9701F9D6114530-6vtk6ynWDJf9L9UzlSODQOG7l92LEt8e@public.gmane.org>
  1 sibling, 1 reply; 4+ messages in thread
From: Schmiedl Christian @ 2013-09-26 14:02 UTC (permalink / raw)
  To: Aleksander Morgado, netdev@vger.kernel.org,
	linux-usb@vger.kernel.org
  Cc: davem@davemloft.net, bjorn@mork.no, dcbw@redhat.com,
	Schemmel Hans-Christoph, Colberg Nicolaus

Aleksander Morgado <aleksander@lanedo.com> writes:

> Cinterion PLXX LTE devices have a 0x0060 product ID, not 0x12d1.
>
> The blacklisting in the serial/option driver does actually use the
> correct PID, as per commit 8ff10bdb14a52e3f25d4ce09e0582a8684c1a6db
> ('USB: Blacklisted Cinterion's PLxx WWAN Interface').

Thanks for patching

Acked-by: Christian Schmiedl <christian.schmiedl@gemalto.com>

Chris



This message and any attachments are intended solely for the addressees and may contain confidential information. Any unauthorized use or disclosure, either whole or partial, is prohibited.
E-mails are susceptible to alteration. Our company shall not be liable for the message if altered, changed or falsified. If you are not the intended recipient of this message, please delete it and notify the sender.
Although all reasonable efforts have been made to keep this transmission free from viruses, the sender will not be liable for damages caused by a transmitted virus

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: qmi_wwan: fix Cinterion PLXX product ID
       [not found]   ` <376FB829F3ECB542B825EAF4D8CA8A9701F9D6114530-6vtk6ynWDJf9L9UzlSODQOG7l92LEt8e@public.gmane.org>
@ 2013-09-30 19:04     ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2013-09-30 19:04 UTC (permalink / raw)
  To: Christian.Schmiedl-av01+Y74gORBDgjK7y7TUQ
  Cc: aleksander-bhGbAngMcJvQT0dZR+AlfA, netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA, bjorn-yOkvZcmFvRU,
	dcbw-H+wXaHxf7aLQT0dZR+AlfA,
	Hans-Christoph.Schemmel-av01+Y74gORBDgjK7y7TUQ,
	Nicolaus.Colberg-av01+Y74gORBDgjK7y7TUQ

From: Schmiedl Christian <Christian.Schmiedl-av01+Y74gORBDgjK7y7TUQ@public.gmane.org>
Date: Thu, 26 Sep 2013 16:02:13 +0200

> Aleksander Morgado <aleksander-bhGbAngMcJvQT0dZR+AlfA@public.gmane.org> writes:
> 
>> Cinterion PLXX LTE devices have a 0x0060 product ID, not 0x12d1.
>>
>> The blacklisting in the serial/option driver does actually use the
>> correct PID, as per commit 8ff10bdb14a52e3f25d4ce09e0582a8684c1a6db
>> ('USB: Blacklisted Cinterion's PLxx WWAN Interface').
> 
> Thanks for patching
> 
> Acked-by: Christian Schmiedl <christian.schmiedl-av01+Y74gORBDgjK7y7TUQ@public.gmane.org>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-09-30 19:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-25 15:02 [PATCH] net: qmi_wwan: fix Cinterion PLXX product ID Aleksander Morgado
     [not found] ` <1380121356-28601-1-git-send-email-aleksander-bhGbAngMcJvQT0dZR+AlfA@public.gmane.org>
2013-09-25 16:10   ` Bjørn Mork
2013-09-26 14:02 ` Schmiedl Christian
     [not found]   ` <376FB829F3ECB542B825EAF4D8CA8A9701F9D6114530-6vtk6ynWDJf9L9UzlSODQOG7l92LEt8e@public.gmane.org>
2013-09-30 19:04     ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).