* [PATCH] dm9601: fix IFF_ALLMULTI handling
@ 2013-09-30 21:28 Peter Korsgaard
2013-09-30 23:49 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2013-09-30 21:28 UTC (permalink / raw)
To: netdev, davem; +Cc: joseph_chang, Peter Korsgaard
Pass-all-multicast is controlled by bit 3 in RX control, not bit 2
(pass undersized frames).
Reported-by: Joseph Chang <joseph_chang@davicom.com.tw>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
drivers/net/usb/dm9601.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c
index 2dbb946..c6867f9 100644
--- a/drivers/net/usb/dm9601.c
+++ b/drivers/net/usb/dm9601.c
@@ -303,7 +303,7 @@ static void dm9601_set_multicast(struct net_device *net)
rx_ctl |= 0x02;
} else if (net->flags & IFF_ALLMULTI ||
netdev_mc_count(net) > DM_MAX_MCAST) {
- rx_ctl |= 0x04;
+ rx_ctl |= 0x08;
} else if (!netdev_mc_empty(net)) {
struct netdev_hw_addr *ha;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dm9601: fix IFF_ALLMULTI handling
2013-09-30 21:28 [PATCH] dm9601: fix IFF_ALLMULTI handling Peter Korsgaard
@ 2013-09-30 23:49 ` David Miller
2013-10-01 6:07 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2013-09-30 23:49 UTC (permalink / raw)
To: peter; +Cc: netdev, joseph_chang
From: Peter Korsgaard <peter@korsgaard.com>
Date: Mon, 30 Sep 2013 23:28:20 +0200
> Pass-all-multicast is controlled by bit 3 in RX control, not bit 2
> (pass undersized frames).
>
> Reported-by: Joseph Chang <joseph_chang@davicom.com.tw>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Applied, thanks.
It would be so much better if these register values were all
properly documented, one by one, with macros.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dm9601: fix IFF_ALLMULTI handling
2013-09-30 23:49 ` David Miller
@ 2013-10-01 6:07 ` Peter Korsgaard
0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2013-10-01 6:07 UTC (permalink / raw)
To: David Miller; +Cc: peter, netdev, joseph_chang
>>>>> "David" == David Miller <davem@davemloft.net> writes:
Hi,
David> Applied, thanks.
Thanks!
David> It would be so much better if these register values were all
David> properly documented, one by one, with macros.
Yes, I know. I'll take a look at getting rid of all the magic values.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-01 6:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-30 21:28 [PATCH] dm9601: fix IFF_ALLMULTI handling Peter Korsgaard
2013-09-30 23:49 ` David Miller
2013-10-01 6:07 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).