* [PATCH] ethernet: moxa: fix incorrect placement of __initdata tag
@ 2013-09-30 13:18 Bartlomiej Zolnierkiewicz
2013-10-01 5:17 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-09-30 13:18 UTC (permalink / raw)
To: David S. Miller; +Cc: Jonas Jensen, netdev, linux-kernel, Kyungmin Park
__initdata tag should be placed between the variable name and equal
sign for the variable to be placed in the intended .init.data section.
In this particular case __initdata is incorrect as moxart_mac_driver
can be used after the driver gets initialized.
Also while at it static-ize moxart_mac_driver.
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/net/ethernet/moxa/moxart_ether.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c
index 83c2091..bd1a2d2 100644
--- a/drivers/net/ethernet/moxa/moxart_ether.c
+++ b/drivers/net/ethernet/moxa/moxart_ether.c
@@ -543,7 +543,7 @@ static const struct of_device_id moxart_mac_match[] = {
{ }
};
-struct __initdata platform_driver moxart_mac_driver = {
+static struct platform_driver moxart_mac_driver = {
.probe = moxart_mac_probe,
.remove = moxart_remove,
.driver = {
--
1.8.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ethernet: moxa: fix incorrect placement of __initdata tag
2013-09-30 13:18 [PATCH] ethernet: moxa: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
@ 2013-10-01 5:17 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-10-01 5:17 UTC (permalink / raw)
To: b.zolnierkie; +Cc: jonas.jensen, netdev, linux-kernel, kyungmin.park
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Date: Mon, 30 Sep 2013 15:18:27 +0200
> __initdata tag should be placed between the variable name and equal
> sign for the variable to be placed in the intended .init.data section.
>
> In this particular case __initdata is incorrect as moxart_mac_driver
> can be used after the driver gets initialized.
>
> Also while at it static-ize moxart_mac_driver.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-01 5:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-30 13:18 [PATCH] ethernet: moxa: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
2013-10-01 5:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).