From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Pfaff Subject: Re: [PATCH v2.40 4/7] ofp-actions: Add separate OpenFlow 1.3 action parser Date: Sun, 29 Sep 2013 19:19:56 -0700 Message-ID: <20130930021956.GB5368@nicira.com> References: <1380241116-7661-1-git-send-email-horms@verge.net.au> <1380241116-7661-5-git-send-email-horms@verge.net.au> <20130927194119.GC17506@nicira.com> <20130930021246.GC4768@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, Ravi K , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Isaku Yamahata To: Simon Horman Return-path: Content-Disposition: inline In-Reply-To: <20130930021246.GC4768-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, Sep 30, 2013 at 11:12:49AM +0900, Simon Horman wrote: > I have written an incremental patch to implement your suggestion > and it seems that a helper function is not necessary. > > For reference the incremental change that I currently have is as follows. > It is a bit noisy but seems clean to me. A quick glance through the incremental shows that we are on the same page. Thanks!