From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [Xen-devel] [PATCH net-next] xen-netfront: convert to GRO API and advertise this feature Date: Mon, 30 Sep 2013 10:43:27 -0400 Message-ID: <20130930144327.GL3106@phenom.dumpdata.com> References: <1379779543-27122-1-git-send-email-wei.liu2@citrix.com> <20130928.153800.327243541797748645.davem@davemloft.net> <1380532331.1302.9.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , netdev@vger.kernel.org, wei.liu2@citrix.com, abchak@juniper.net, xen-devel@lists.xen.org To: Ian Campbell Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:51472 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754343Ab3I3Onk (ORCPT ); Mon, 30 Sep 2013 10:43:40 -0400 Content-Disposition: inline In-Reply-To: <1380532331.1302.9.camel@kazak.uk.xensource.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Sep 30, 2013 at 10:12:11AM +0100, Ian Campbell wrote: > On Sat, 2013-09-28 at 15:38 -0400, David Miller wrote: > > From: Wei Liu > > Date: Sat, 21 Sep 2013 17:05:43 +0100 > > > > > @@ -1371,7 +1373,8 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev) > > > netif_napi_add(netdev, &np->napi, xennet_poll, 64); > > > netdev->features = NETIF_F_IP_CSUM | NETIF_F_RXCSUM | > > > NETIF_F_GSO_ROBUST; > > > - netdev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO; > > > + netdev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO | > > > + NETIF_F_GRO; > > > > Please post a new version of this patch with the feedback you've been > > given integrated, in particular with this part removed because it is > > not necessary. > > > > Ian, please review the patch when Wei posts it. > > I will, but note: > $ ./scripts/get_maintainer.pl -f drivers/net/xen-netfront.c > Konrad Rzeszutek Wilk (supporter:XEN HYPERVISOR IN...) > Jeremy Fitzhardinge (supporter:XEN HYPERVISOR IN...) > xen-devel@lists.xensource.com (moderated list:XEN HYPERVISOR IN...) > virtualization@lists.linux-foundation.org (open list:XEN HYPERVISOR IN...) > netdev@vger.kernel.org (open list:NETWORKING DRIVERS) > linux-kernel@vger.kernel.org (open list) > > Strictly speaking I maintain netback not front, so Wei please remember > to CC the right people (mainly Konrad) as well as me. Which was Acked: http://mid.gmane.org/20130924163036.GB13979@phenom.dumpdata.com > > BTW I think this separation is a good thing since it keeps changes to > the protocol "honest". Doesn't matter so much for this particular patch > since don't think it actually touches the protocol. > > Ian. > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel