netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ricardo.ribalda@gmail.com
Cc: joe@perches.com, jg1.han@samsung.com, gregkh@linuxfoundation.org,
	wfp5p@virginia.edu, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ll_temac: Reset dma descriptors on ndo_open
Date: Tue, 01 Oct 2013 02:01:34 -0400 (EDT)	[thread overview]
Message-ID: <20131001.020134.756782177490714135.davem@davemloft.net> (raw)
In-Reply-To: <CAPybu_0OrwTo7CkuauRpu_ohQRY80U6BJDXQ6=KC0caOFiFCQA@mail.gmail.com>

From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Date: Tue, 1 Oct 2013 07:46:31 +0200

> What if I move
>        lp->tx_bd_ci = 0;
>        lp->tx_bd_next = 0;
>        lp->tx_bd_tail = 0;
>        lp->rx_bd_ci = 0;
> 
> to temac_dma_bd_init? Will this be more correct?

Yes, that would be a lot better.

  reply	other threads:[~2013-10-01  6:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27 11:24 [PATCH] ll_temac: Reset dma descriptors on ndo_open Ricardo Ribalda Delgado
2013-10-01  4:21 ` David Miller
2013-10-01  5:46   ` Ricardo Ribalda Delgado
2013-10-01  6:01     ` David Miller [this message]
2013-10-01  6:18       ` Ricardo Ribalda Delgado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131001.020134.756782177490714135.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ricardo.ribalda@gmail.com \
    --cc=wfp5p@virginia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).