From: David Miller <davem@davemloft.net>
To: hns@goldelico.com
Cc: j.dumon@option.com, marek.belisko@gmail.com,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication
Date: Thu, 03 Oct 2013 15:29:07 -0400 (EDT) [thread overview]
Message-ID: <20131003.152907.2144013596237714581.davem@davemloft.net> (raw)
In-Reply-To: <B1808224-5850-41E3-9A8F-0F350F84FF89@goldelico.com>
From: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Date: Wed, 2 Oct 2013 09:00:18 +0200
> From f5c7e15b61f2ce4fe3105ff914f6bfaf5d74af0d Mon Sep 17 00:00:00 2001
> From: "H. Nikolaus Schaller" <hns@goldelico.com>
> Date: Thu, 15 Nov 2012 14:40:57 +0100
> Subject: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION
> GTM601 during RING indication
>
> It has been observed that the GTM601 with 1.7 firmware sometimes sends a value
> wIndex that has bit 0x04 set instead of being reset as the code expects. So we
> mask it for the error check.
>
> See http://lists.goldelico.com/pipermail/gta04-owner/2012-February/001643.html
>
> Signed-off-by: NeilBrown <neilb@suse.de>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.de>
I think we should look more deeply into what this bit might mean
and why the firmware might be setting it before we even consider
applying a patch like this one.
next prev parent reply other threads:[~2013-10-03 19:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 7:00 [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication Dr. H. Nikolaus Schaller
2013-10-03 19:29 ` David Miller [this message]
[not found] ` <20131003.152907.2144013596237714581.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-10-03 19:40 ` Dr. H. Nikolaus Schaller
2013-10-03 20:00 ` David Miller
[not found] ` <20131003.160049.199880461500344692.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-10-04 6:22 ` Dr. H. Nikolaus Schaller
2013-12-13 14:43 ` Dr. H. Nikolaus Schaller
2013-12-16 19:40 ` Dan Williams
2013-12-17 19:56 ` Dr. H. Nikolaus Schaller
[not found] ` <174CD81C-6425-4560-A3FA-3BFAA83BA770-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2013-12-17 22:27 ` Dan Williams
2013-12-18 13:16 ` Dr. H. Nikolaus Schaller
2013-12-18 17:49 ` Dan Williams
2013-12-19 7:48 ` Dr. H. Nikolaus Schaller
2014-01-06 16:07 ` [PATCH] hso: fix handling of modem port SERIAL_STATE notifications Dan Williams
2014-01-06 21:30 ` David Miller
2014-01-06 21:39 ` Dan Williams
2014-01-06 21:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131003.152907.2144013596237714581.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hns@goldelico.com \
--cc=j.dumon@option.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).