From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 08/19 v2] net: atl1c: Change variable type to bool Date: Thu, 03 Oct 2013 15:41:08 -0400 (EDT) Message-ID: <20131003.154108.1994295488096974739.davem@davemloft.net> References: <1380716391-20214-1-git-send-email-peter.senna@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jcliburn@gmail.com, chris.snook@gmail.com, jkosina@suse.cz, rdunlap@infradead.org, standby24x7@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org To: peter.senna@gmail.com Return-path: In-Reply-To: <1380716391-20214-1-git-send-email-peter.senna@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Peter Senna Tschudin Date: Wed, 2 Oct 2013 14:19:48 +0200 > The variable ret is only assigned the values true and false. > The function atl1c_read_eeprom already returns bool. Change > ret type to bool. > > The simplified semantic patch that find this problem is as > follows (http://coccinelle.lip6.fr/): > > @exists@ > type T; > identifier b; > @@ > - T > + bool > b = ...; > ... when any > b = \(true\|false\) > > Signed-off-by: Peter Senna Tschudin Applied.