From: David Miller <davem@davemloft.net>
To: andrea.merello@gmail.com
Cc: jie.yang@atheros.com, xiong.huang@atheros.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atl1e: enable support for NETIF_F_RXALL and NETIF_F_RXCRC features
Date: Thu, 03 Oct 2013 17:01:26 -0400 (EDT) [thread overview]
Message-ID: <20131003.170126.2297161431158026731.davem@davemloft.net> (raw)
In-Reply-To: <1380827917-22992-1-git-send-email-andrea.merello@gmail.com>
From: Andrea Merello <andrea.merello@gmail.com>
Date: Thu, 3 Oct 2013 21:18:37 +0200
> This patch allows (optionally, via ethtool) the atl1e NIC to:
> - Receive bad frames (runt, bad-fcs, etc..)
> - Receive full frames without stripping the FCS.
>
> This has been tested on my board by injecting runt and bad-fcs
> frames with a FPGA-based device.
>
> The particular scenario of receiving very short frames (<4 bytes)
> without passing FCS to the upper layer has been also tested:
> This could be potentially dangerous because the driver performs a
> 4 byte subtraction on the frame length, but I finally have NOT
> added anything to avoid this because it seems the NIC always
> discards frames so much short..
> If someone still have some reason to worry about this, please
> tell me.. I will add an explicit SW check..
>
> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
Looks good, applied, thanks Andrea.
prev parent reply other threads:[~2013-10-03 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 19:18 [PATCH] atl1e: enable support for NETIF_F_RXALL and NETIF_F_RXCRC features Andrea Merello
2013-10-03 21:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131003.170126.2297161431158026731.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrea.merello@gmail.com \
--cc=jie.yang@atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiong.huang@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).