From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tcp/dccp: remove twchain
Date: Thu, 03 Oct 2013 17:51:07 -0400 (EDT) [thread overview]
Message-ID: <20131003.175107.1919190333940976775.davem@davemloft.net> (raw)
In-Reply-To: <1380784922.19002.198.camel@edumazet-glaptop.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 03 Oct 2013 00:22:02 -0700
> Current inet_ehash_bucket contains two chains, one for ESTABLISH (and
> friend states) sockets, another for TIME_WAIT sockets only.
>
> As the hash table is sized to get at most one socket per bucket, it
> makes little sense to have separate twchain, as it makes the lookup
> slightly more complicated, and doubles hash table memory usage.
The idea was that long standing time-wait sockets should be forced to
provably never appear in same hash chains and thus cause interference
with lookups on established sockets.
On the other hand, moving sockets between these two tables has a
non-trivial cost, and synchronization complexity.
So perhaps your change gives the right tradeoff.
Eric this patch needs to be respun against current net-next
in order for it to apply cleanly, please do that and I'll add
it.
Thanks!
next prev parent reply other threads:[~2013-10-03 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 7:22 [PATCH net-next] tcp/dccp: remove twchain Eric Dumazet
2013-10-03 20:04 ` Ben Hutchings
2013-10-03 20:31 ` Eric Dumazet
2013-10-03 21:51 ` David Miller [this message]
2013-10-03 21:58 ` Eric Dumazet
2013-10-03 22:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131003.175107.1919190333940976775.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox