From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] ip: make -resolve addr to print names rather than
 addresses
Date: Fri, 4 Oct 2013 11:25:30 -0700
Message-ID: <20131004112530.1cab081c@nehalam.linuxnetplumber.net>
References: <1380574908-9220-1-git-send-email-kerolasa@iki.fi>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: Sami Kerola <kerolasa@iki.fi>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pa0-f49.google.com ([209.85.220.49]:40613 "EHLO
	mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751899Ab3JDSZf (ORCPT
	<rfc822;netdev@vger.kernel.org>); Fri, 4 Oct 2013 14:25:35 -0400
Received: by mail-pa0-f49.google.com with SMTP id ld10so4527174pab.22
        for <netdev@vger.kernel.org>; Fri, 04 Oct 2013 11:25:34 -0700 (PDT)
In-Reply-To: <1380574908-9220-1-git-send-email-kerolasa@iki.fi>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 30 Sep 2013 22:01:48 +0100
Sami Kerola <kerolasa@iki.fi> wrote:

> As a system admin I occasionally want to be able to check that all
> interfaces has a name in DNS or /etc/hosts file.
> 
> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
> ---
>  ip/ipaddress.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index 1c3e4da..d02eaaf 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -636,7 +636,7 @@ int print_addrinfo(const struct sockaddr_nl *who, struct nlmsghdr *n,
>  		fprintf(fp, "    family %d ", ifa->ifa_family);
>  
>  	if (rta_tb[IFA_LOCAL]) {
> -		fprintf(fp, "%s", rt_addr_n2a(ifa->ifa_family,
> +		fprintf(fp, "%s", format_host(ifa->ifa_family,
>  					      RTA_PAYLOAD(rta_tb[IFA_LOCAL]),
>  					      RTA_DATA(rta_tb[IFA_LOCAL]),
>  					      abuf, sizeof(abuf)));
> @@ -647,7 +647,7 @@ int print_addrinfo(const struct sockaddr_nl *who, struct nlmsghdr *n,
>  			fprintf(fp, "/%d ", ifa->ifa_prefixlen);
>  		} else {
>  			fprintf(fp, " peer %s/%d ",
> -				rt_addr_n2a(ifa->ifa_family,
> +				format_host(ifa->ifa_family,
>  					    RTA_PAYLOAD(rta_tb[IFA_ADDRESS]),
>  					    RTA_DATA(rta_tb[IFA_ADDRESS]),
>  					    abuf, sizeof(abuf)),
> @@ -657,14 +657,14 @@ int print_addrinfo(const struct sockaddr_nl *who, struct nlmsghdr *n,
>  
>  	if (rta_tb[IFA_BROADCAST]) {
>  		fprintf(fp, "brd %s ",
> -			rt_addr_n2a(ifa->ifa_family,
> +			format_host(ifa->ifa_family,
>  				    RTA_PAYLOAD(rta_tb[IFA_BROADCAST]),
>  				    RTA_DATA(rta_tb[IFA_BROADCAST]),
>  				    abuf, sizeof(abuf)));
>  	}
>  	if (rta_tb[IFA_ANYCAST]) {
>  		fprintf(fp, "any %s ",
> -			rt_addr_n2a(ifa->ifa_family,
> +			format_host(ifa->ifa_family,
>  				    RTA_PAYLOAD(rta_tb[IFA_ANYCAST]),
>  				    RTA_DATA(rta_tb[IFA_ANYCAST]),
>  				    abuf, sizeof(abuf)));

This shouldn't be the default. It will change the result that user's expect now.