From: David Miller <davem@davemloft.net>
To: festevam@gmail.com
Cc: edumazet@google.com, hannes@strressinduktion.org,
netdev@vger.kernel.org, olof@lixom.net,
fabio.estevam@freescale.com
Subject: Re: [PATCH] net: secure_seq: Move net_secret_init() definition into CONFIG_IPV6 if block
Date: Sat, 05 Oct 2013 16:27:52 -0400 (EDT) [thread overview]
Message-ID: <20131005.162752.155685316245760253.davem@davemloft.net> (raw)
In-Reply-To: <1381003790-12731-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Sat, 5 Oct 2013 17:09:50 -0300
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Commit 9a3bab6b05 (net: net_secret should not depend on TCP) introduced
> the following build warning when CONFIG_IPV6 is not selected:
>
> net/core/secure_seq.c:17:13: warning: 'net_secret_init' defined but not used [-Wunused-function]
>
> Fix it by moving net_secret_init(void) inside the '#if IS_ENABLED(CONFIG_IPV6)'
> block.
>
> Reported-by: Olof Johansson <olof@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
seq_scale is used by secure_tcp_sequence_number, which is only protected
by CONFIG_INET. I have no idea how you can get this build problem.
And I cannot reproduce it here:
[davem@drr net]$ egrep CONFIG_IPV6 .config
# CONFIG_IPV6 is not set
[davem@drr net]$ make net/core/secure_seq.o
scripts/kconfig/conf --silentoldconfig Kconfig
make[1]: Nothing to be done for `all'.
make[1]: Nothing to be done for `relocs'.
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CC net/core/secure_seq.o
[davem@drr net]$
Furthermore your commit message is talking about net_secret_init but
your patch does things with seq_scale.
I'm not applying this patch.
next prev parent reply other threads:[~2013-10-05 20:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 20:09 [PATCH] net: secure_seq: Move net_secret_init() definition into CONFIG_IPV6 if block Fabio Estevam
2013-10-05 20:26 ` Fabio Estevam
2013-10-05 20:27 ` David Miller [this message]
2013-10-06 5:25 ` Olof Johansson
2013-10-06 16:29 ` Fabio Estevam
-- strict thread matches above, loose matches on Subject: below --
2013-10-05 20:56 Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131005.162752.155685316245760253.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=hannes@strressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).