From: David Miller <davem@davemloft.net>
To: ebiederm@xmission.com
Cc: fruggeri@aristanetworks.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: Separate the close_list and the unreg_list v2
Date: Mon, 07 Oct 2013 15:22:38 -0400 (EDT) [thread overview]
Message-ID: <20131007.152238.779958484281422820.davem@davemloft.net> (raw)
In-Reply-To: <87txgv9ltu.fsf@xmission.com>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Sat, 05 Oct 2013 19:26:05 -0700
>
> Separate the unreg_list and the close_list in dev_close_many preventing
> dev_close_many from permuting the unreg_list. The permutations of the
> unreg_list have resulted in cases where the loopback device is accessed
> it has been freed in code such as dst_ifdown. Resulting in subtle memory
> corruption.
>
> This is the second bug from sharing the storage between the close_list
> and the unreg_list. The issues that crop up with sharing are
> apparently too subtle to show up in normal testing or usage, so let's
> forget about being clever and use two separate lists.
>
> v2: Make all callers pass in a close_list to dev_close_many
>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
> ---
>
> Sending the complete diff because this version is actually more
> readable and more obviously correct.
I'll apply this, thanks Eric.
next prev parent reply other threads:[~2013-10-07 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 13:18 [PATCH net-next] net: Separate the close_list and the unreg_list Francesco Ruggeri
2013-10-06 2:13 ` Eric W. Biederman
2013-10-06 2:26 ` [PATCH] net: Separate the close_list and the unreg_list v2 Eric W. Biederman
2013-10-07 19:22 ` David Miller [this message]
2013-10-07 22:45 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131007.152238.779958484281422820.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=fruggeri@aristanetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).