From: David Miller <davem@davemloft.net>
To: paul.durrant@citrix.com
Cc: xen-devel@lists.xen.org, netdev@vger.kernel.org,
xixiong@amazon.com, msw@amazon.com, annie.li@oracle.com,
wei.liu2@citrix.com, Ian.Campbell@citrix.com
Subject: Re: [PATCH net-next] xen-netback: fix xenvif_count_skb_slots()
Date: Mon, 07 Oct 2013 15:36:22 -0400 (EDT) [thread overview]
Message-ID: <20131007.153622.1392772445100851507.davem@davemloft.net> (raw)
In-Reply-To: <1380903983-27429-1-git-send-email-paul.durrant@citrix.com>
From: Paul Durrant <paul.durrant@citrix.com>
Date: Fri, 4 Oct 2013 17:26:23 +0100
> Commit 4f0581d25827d5e864bcf07b05d73d0d12a20a5c introduced an error into
> xenvif_count_skb_slots() for skbs with a linear area spanning a page
> boundary. The alignment of skb->data needs to be taken into account, not
> just the head length. This patch fixes the issue by dry-running the code
> from xenvif_gop_skb() (and adjusting the comment above the function to note
> that).
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
There seems to be a lot of back and forth about what is the most
desirable way forward wrt. this commit and another similar one.
Please advise.
next prev parent reply other threads:[~2013-10-07 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 16:26 [PATCH net-next] xen-netback: fix xenvif_count_skb_slots() Paul Durrant
2013-10-07 0:06 ` Matt Wilson
2013-10-07 0:07 ` Matt Wilson
2013-10-07 10:17 ` Paul Durrant
2013-10-07 9:50 ` [Xen-devel] " David Vrabel
2013-10-07 10:23 ` Paul Durrant
2013-10-07 10:37 ` Paul Durrant
2013-10-07 10:53 ` Wei Liu
2013-10-07 10:01 ` Wei Liu
2013-10-07 10:12 ` Paul Durrant
2013-10-07 19:36 ` David Miller [this message]
2013-10-07 20:03 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131007.153622.1392772445100851507.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ian.Campbell@citrix.com \
--cc=annie.li@oracle.com \
--cc=msw@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xixiong@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).