netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: linux@roeck-us.net
Cc: alex.bluesman.smirnov@gmail.com, dbaryshkov@gmail.com,
	netdev@vger.kernel.org, linux-zigbee-devel@lists.sourceforge.net
Subject: Re: [PATCH] net: af802154: Fix wrong structure declaration
Date: Tue, 08 Oct 2013 15:49:10 -0400 (EDT)	[thread overview]
Message-ID: <20131008.154910.1164614425435689551.davem@davemloft.net> (raw)
In-Reply-To: <1381095841-15031-1-git-send-email-linux@roeck-us.net>

From: Guenter Roeck <linux@roeck-us.net>
Date: Sun,  6 Oct 2013 14:44:01 -0700

> net_devce doesn't exist.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

This is simply rediculous.

The reason I say this is that every user of this header includes
net/sock.h which in turn includes linux/skbuff.h and linux/netdevice.h
which therefore bring in all the necessary structure definitions.

Really, the most correct change is to make af802154.h explicitly
include those header files.

      parent reply	other threads:[~2013-10-08 19:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-06 21:44 [PATCH] net: af802154: Fix wrong structure declaration Guenter Roeck
     [not found] ` <1381095841-15031-1-git-send-email-linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-10-06 22:20   ` Joe Perches
2013-10-06 23:18     ` Guenter Roeck
2013-10-08 19:49 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131008.154910.1164614425435689551.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alex.bluesman.smirnov@gmail.com \
    --cc=dbaryshkov@gmail.com \
    --cc=linux-zigbee-devel@lists.sourceforge.net \
    --cc=linux@roeck-us.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).