[PATCH] net: af802154: Fix wrong structure declaration

[PATCH] net: af802154: Fix wrong structure declaration

[Guenter Roeck]

net_devce doesn't exist.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 net/ieee802154/af802154.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ieee802154/af802154.h b/net/ieee802154/af802154.h
index b1ec525..62f5f63 100644
--- a/net/ieee802154/af802154.h
+++ b/net/ieee802154/af802154.h
@@ -25,7 +25,7 @@
 #define AF802154_H
 
 struct sk_buff;
-struct net_devce;
+struct net_device;
 extern struct proto ieee802154_raw_prot;
 extern struct proto ieee802154_dgram_prot;
 void ieee802154_raw_deliver(struct net_device *dev, struct sk_buff *skb);
-- 
1.7.9.7

Re: [PATCH] net: af802154: Fix wrong structure declaration

[Joe Perches]

On Sun, 2013-10-06 at 14:44 -0700, Guenter Roeck wrote:
> net_devce doesn't exist.
[]
> diff --git a/net/ieee802154/af802154.h b/net/ieee802154/af802154.h
[]
> @@ -25,7 +25,7 @@
>  #define AF802154_H
>  
>  struct sk_buff;
> -struct net_devce;
> +struct net_device;

That argues more for deletion than correction.



------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk

Re: [PATCH] net: af802154: Fix wrong structure declaration

[Guenter Roeck]

On 10/06/2013 03:20 PM, Joe Perches wrote:
> On Sun, 2013-10-06 at 14:44 -0700, Guenter Roeck wrote:
>> net_devce doesn't exist.
> []
>> diff --git a/net/ieee802154/af802154.h b/net/ieee802154/af802154.h
> []
>> @@ -25,7 +25,7 @@
>>   #define AF802154_H
>>
>>   struct sk_buff;
>> -struct net_devce;
>> +struct net_device;
>
> That argues more for deletion than correction.
>

I thought the idea was to ensure that every structure is declared.
In this case it appears that the structure happens to be declared
in other include files, so we are lucky. On the other side, if so,
"struct proto", "struct net" and "struct ieee802154_addr" should
probably be declared as well ...

Ultimately, I don't really care one way or another. I just happened
to stumble over it. Fine with me to remove it. Maybe the maintainers
should decide what if anything to do.

Guenter

Re: [PATCH] net: af802154: Fix wrong structure declaration

[David Miller]

From: Guenter Roeck <linux@roeck-us.net>
Date: Sun,  6 Oct 2013 14:44:01 -0700

> net_devce doesn't exist.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

This is simply rediculous.

The reason I say this is that every user of this header includes
net/sock.h which in turn includes linux/skbuff.h and linux/netdevice.h
which therefore bring in all the necessary structure definitions.

Really, the most correct change is to make af802154.h explicitly
include those header files.