From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] ipv6: make lookups simpler and faster
Date: Tue, 08 Oct 2013 23:21:25 -0400 (EDT) [thread overview]
Message-ID: <20131008.232125.1605815898898029345.davem@davemloft.net> (raw)
In-Reply-To: <1380840149.19002.256.camel@edumazet-glaptop.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 03 Oct 2013 15:42:29 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> TCP listener refactoring, part 4 :
>
> To speed up inet lookups, we moved IPv4 addresses from inet to struct
> sock_common
>
> Now is time to do the same for IPv6, because it permits us to have fast
> lookups for all kind of sockets, including upcoming SYN_RECV.
>
> Getting IPv6 addresses in TCP lookups currently requires two extra cache
> lines, plus a dereference (and memory stall).
>
> inet6_sk(sk) does the dereference of inet_sk(__sk)->pinet6
>
> This patch is way bigger than its IPv4 counter part, because for IPv4,
> we could add aliases (inet_daddr, inet_rcv_saddr), while on IPv6,
> it's not doable easily.
>
> inet6_sk(sk)->daddr becomes sk->sk_v6_daddr
> inet6_sk(sk)->rcv_saddr becomes sk->sk_v6_rcv_saddr
>
> And timewait socket also have tw->tw_v6_daddr & tw->tw_v6_rcv_saddr
> at the same offset.
>
> We get rid of INET6_TW_MATCH() as INET6_MATCH() is now the generic
> macro.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks a lot Eric.
next prev parent reply other threads:[~2013-10-09 3:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 22:42 [PATCH net-next 2/2] ipv6: make lookups simpler and faster Eric Dumazet
2013-10-09 3:21 ` David Miller [this message]
2013-10-09 4:07 ` David Miller
2013-10-09 4:26 ` Eric Dumazet
2013-10-09 5:11 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008.232125.1605815898898029345.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).